Bug 512027

Summary: Review Request: zikula-module-News - Manages news articles on your Zikula site
Product: [Fedora] Fedora Reporter: Paul W. Frields <stickster>
Component: Package ReviewAssignee: David Nalley <david>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: david, fedora-package-review, ian, notting
Target Milestone: ---Flags: david: fedora-review+
tibbs: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Fixed In Version: 2.4.1-2.fc11 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-07-23 19:09:15 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On:    
Bug Blocks: 512025    

Description Paul W. Frields 2009-07-16 00:02:53 UTC
Spec URL: http://pfrields.fedorapeople.org/packages/SPECS/zikula-module-News.spec
SRPM URL: http://pfrields.fedorapeople.org/packages/SRPMS/zikula-module-News-2.4.1-1.fc11.src.rpm
News module to manage news articles on your site. Provides
multi-categorization, scheduled publishing, the basic management
features and includes some highly customizable blocks and plugins for
the Content module.

Comment 1 David Nalley 2009-07-16 04:34:46 UTC
MUST: rpmlint must be run on every package. The output should be posted in the review.

[ke4qqq@nalleyt61 SPECS]$ rpmlint ./zikula-module-News.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
[ke4qqq@nalleyt61 SPECS]$ rpmlint ../SRPMS/zikula-module-News-2.4.1-1.fc11.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[ke4qqq@nalleyt61 SPECS]$ rpmlint ../RPMS/noarch/zikula-module-News-2.4.1-1.fc11.noarch.rpm 
zikula-module-News.noarch: W: incoherent-version-in-changelog 0.1.3-1 ['2.4.1-1.fc11', '2.4.1-1']
zikula-module-News.noarch: E: zero-length /usr/share/zikula/modules/News/pnstyle/index.html
zikula-module-News.noarch: E: zero-length /usr/share/zikula/modules/News/pntemplates/config/index.html
zikula-module-News.noarch: E: zero-length /usr/share/zikula/modules/News/pnuserapi/index.html
zikula-module-News.noarch: E: zero-length /usr/share/zikula/modules/News/pnlang/eng/index.html
zikula-module-News.noarch: E: zero-length /usr/share/zikula/modules/News/index.html
zikula-module-News.noarch: E: zero-length /usr/share/doc/zikula-module-News-2.4.1/index.html
zikula-module-News.noarch: E: zero-length /usr/share/zikula/modules/News/pntemplates/plugins/index.html
zikula-module-News.noarch: E: zero-length /usr/share/zikula/modules/News/pnlang/index.html
zikula-module-News.noarch: E: zero-length /usr/share/zikula/modules/News/pnimages/index.html
zikula-module-News.noarch: E: zero-length /usr/share/zikula/modules/News/pntemplates/contenttype/index.html
zikula-module-News.noarch: E: zero-length /usr/share/zikula/modules/News/pntemplates/index.html
zikula-module-News.noarch: E: zero-length /usr/share/zikula/modules/News/pncontenttypesapi/index.html
zikula-module-News.noarch: E: zero-length /usr/share/zikula/modules/News/pnblocks/index.html
zikula-module-News.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/zikula-module-News-2.4.1/NewsTODO.txt
zikula-module-News.noarch: E: zero-length /usr/share/zikula/modules/News/pnjavascript/index.html
1 packages and 0 specfiles checked; 14 errors, 2 warnings.

Paul: You can probably purge the zero-length index.html files with this: 
find ${RPM_BUILD_ROOT} -empty -exec rm -f {} \;

OK: The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. 
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines .
Appears to be GPL+

FIX: The License field in the package spec file must match the actual license.

Based on the GPL+ entry in http://fedoraproject.org/wiki/Licensing:
"A GPL or LGPL licensed package that lacks any statement of what version that it's licensed under in the source code/program output/accompanying docs is technically licensed under *any* version of the GPL or LGPL, not just the version in whatever COPYING file they include. "

I think that this is GPL+ instead of GPLv2 as every mention in source is 
* @license    GNU/GPL - http://www.gnu.org/copyleft/gpl.html
and there appears to be no other documentation included with source. 

NA: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc
OK: The spec file must be written in American English.
OK: The spec file for the package MUST be legible. 
OK: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines 

cac873b9b459d64b9aaceeeea9a8a136  ./News_2.4.1.zip
cac873b9b459d64b9aaceeeea9a8a136  ./News_2.4.1.zip.1

OK: The package MUST successfully compile and build into binary rpms on at least one primary architecture. 
NA: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line. 
OK: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense.
NA: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
NA: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. 
NA: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker. 
OK: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. 
OK: A Fedora package must not list a file more than once in the spec file's %files listings. 
OK: Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line. 
OK: Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). 
OK: Each package must consistently use macros. 
OK: The package must contain code, or permissable content. 
NA: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity). 
OK: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. 
NA: Header files must be in a -devel package. 
NA: Static libraries must be in a -static package. 
NA: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for directory ownership and usability). 
NA: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. 
NA: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} 
NA: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built.
NA: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation. 
OK: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time. 
OK: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). 
OK: All filenames in rpm packages must be valid UTF-8.

Comment 2 Paul W. Frields 2009-07-17 01:41:44 UTC

Thanks for the review David -- I shouldn't have tried to complete this so quickly the other night.  The new files have no rpmlint errors, and the License is fixed as well.

Comment 3 David Nalley 2009-07-17 11:45:44 UTC
That appears to have fixed all of the outstanding issues. 

Thanks for the fast response


Comment 4 Paul W. Frields 2009-07-17 19:02:14 UTC
New Package CVS Request
Package Name: zikula-module-News
Short Description: Manages news articles on your Zikula site
Owners: stickster ke4qqq sparks
Branches: F-11

Comment 5 Jason Tibbitts 2009-07-17 19:53:13 UTC
There does not seem to be an active Fedora account named "stickster".

Comment 6 Paul W. Frields 2009-07-17 20:27:32 UTC
New Package CVS Request
Package Name: zikula-module-News
Short Description: Manages news articles on your Zikula site
Owners: pfrields ke4qqq sparks
Branches: F-11

Comment 7 Kevin Fenzi 2009-07-19 20:50:31 UTC
cvs done.

Comment 8 Fedora Update System 2009-07-22 21:09:38 UTC
zikula-module-News-2.4.1-2.fc11 has been submitted as an update for Fedora 11.

Comment 9 Fedora Update System 2009-07-23 19:09:10 UTC
zikula-module-News-2.4.1-2.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Paul W. Frields 2009-07-28 18:30:44 UTC
Package Change Request
Package Name: zikula-module-News
New Branches: EL-5
Owners: pfrields ke4qqq sparks

Comment 11 Jason Tibbitts 2009-07-29 01:01:43 UTC
CVS done.