Bug 512636
| Summary: | Review Request: ibus-table-xinhua - Xin Hua table of IBus Table. | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Caius Chance <K9> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, panemade |
| Target Milestone: | --- | Keywords: | i18n |
| Target Release: | --- | Flags: | panemade:
fedora-review+
j: fedora-cvs+ |
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-08-07 04:39:42 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Caius Chance
2009-07-20 05:16:04 UTC
Review: + package builds in mock (rawhide i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1488962 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 18b35b4e6ba0241937ba5aea0115455fd034fefc ibus-table-xinhua-1.2.0.20090720.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + ibus-table-createdb scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI application Suggestion: 1) use configure instead autogen.sh 2) you already requires ibus-table then what is need to own %dir %{_datadir}/ibus-table %dir %{_datadir}/ibus-table/icons %dir %{_datadir}/ibus-table/tables 3) drop BuildRequires: gettext-devel >= 0.17, automake >= 1.10 Spec URL: http://fedorapeople.org/~cchance/rpms/devel/ibus-table-xinhua.spec SRPM URL: http://fedorapeople.org/~cchance/rpms/devel/ibus-table-xinhua-1.2.0.20090720-2.fc12.src.rpm Description: Xin Hua table of IBus Table. New Package CVS Request ======================= Package Name: ibus-table-xinhua Short Description: Xin Hua table of IBus Table Owners: cchance Branches: F-11 EL-6 InitialCC: i18n-team We cannot create EL-6 branches yet. I imagine we'd at least have to wait until RHEL-6 is actually released. Note also that there's currently an issue with the CVS server, so while this package has been created in pkgdb, it's not yet branched in CVS. I will fix that as soon as things return to normal. OK, the issue is sorted. CVS done (aside from the EL-6 branch, of course). built on rawhide |