Spec URL: http://fedorapeople.org/~cchance/rpms/devel/ibus-table-xinhua.spec SRPM URL: http://fedorapeople.org/~cchance/rpms/devel/ibus-table-xinhua-1.2.0.20090720-1.fc12.src.rpm Description: Xin Hua table of IBus Table.
Review: + package builds in mock (rawhide i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1488962 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 18b35b4e6ba0241937ba5aea0115455fd034fefc ibus-table-xinhua-1.2.0.20090720.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + ibus-table-createdb scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI application Suggestion: 1) use configure instead autogen.sh 2) you already requires ibus-table then what is need to own %dir %{_datadir}/ibus-table %dir %{_datadir}/ibus-table/icons %dir %{_datadir}/ibus-table/tables 3) drop BuildRequires: gettext-devel >= 0.17, automake >= 1.10
Spec URL: http://fedorapeople.org/~cchance/rpms/devel/ibus-table-xinhua.spec SRPM URL: http://fedorapeople.org/~cchance/rpms/devel/ibus-table-xinhua-1.2.0.20090720-2.fc12.src.rpm Description: Xin Hua table of IBus Table.
http://koji.fedoraproject.org/koji/taskinfo?taskID=1493933 APPROVED.
New Package CVS Request ======================= Package Name: ibus-table-xinhua Short Description: Xin Hua table of IBus Table Owners: cchance Branches: F-11 EL-6 InitialCC: i18n-team
We cannot create EL-6 branches yet. I imagine we'd at least have to wait until RHEL-6 is actually released. Note also that there's currently an issue with the CVS server, so while this package has been created in pkgdb, it's not yet branched in CVS. I will fix that as soon as things return to normal.
OK, the issue is sorted. CVS done (aside from the EL-6 branch, of course).
built on rawhide