Bug 512954
| Summary: | Review Request: opencryptoki - Implementation of the PKCS#11 (Cryptoki) specification v2.11 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michal Schmidt <mschmidt> |
| Component: | Package Review | Assignee: | Dan Horák <dan> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, key, notting, rrelyea |
| Target Milestone: | --- | Flags: | dan:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-07-28 11:46:47 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Michal Schmidt
2009-07-21 13:34:31 UTC
(In reply to comment #0) > BTW, openCryptoki can provide access to interesting cryptographic hardware on > s390, but it's not what I'm focusing on for now. And I am interested exactly in the s390(x) stuff and have an almost ready package too :-) Updated spec and SRPM: http://michich.fedorapeople.org/openCryptoki/opencryptoki.spec http://michich.fedorapeople.org/openCryptoki/opencryptoki-2.2.8-4.fc11.src.rpm *** Bug 426152 has been marked as a duplicate of this bug. *** One more update: http://michich.fedorapeople.org/openCryptoki/opencryptoki.spec http://michich.fedorapeople.org/openCryptoki/opencryptoki-2.2.8-5.fc11.src.rpm The only change from -4 is that opencryptoki now Requires opencryptoki-libs using arch-specific dependency. formal review is here, see the notes below: OK source files match upstream: c20e52f19a22cb9695b8298ca11481f3106e3c8d opencryptoki-2.2.8.tar.bz2 OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK license field matches the actual license. OK license is open source-compatible (CPL). License text included in package. OK latest version is being packaged. OK BuildRequires are proper. OK compiler flags are appropriate. OK %clean is present. OK package builds in mock (Rawhide/x86_64). OK debuginfo package looks complete. OK rpmlint is silent. OK final provides and requires look sane. N/A %check is present and all tests pass. OK no shared libraries are added to the regular linker search paths - extra ld.so.conf file added OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK correct scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK headers in devel OK no pkgconfig files. OK no libtool .la droppings. OK not a GUI app. - rpmlint complains a bit: opencryptoki.x86_64: W: non-standard-gid /var/lib/opencryptoki pkcs11 opencryptoki.x86_64: E: non-standard-dir-perm /var/lib/opencryptoki 0770 => this is correct setup opencryptoki.x86_64: W: incoherent-init-script-name pkcsslotd ('opencryptoki', 'opencryptokid') => harmless, can be ignored opencryptoki-libs.x86_64: W: non-conffile-in-etc /etc/ld.so.conf.d/opencryptoki-x86_64.conf => this is OK, the file shouldn't be edited by user opencryptoki-libs.x86_64: W: dangling-relative-symlink /usr/lib64/opencryptoki/methods ../../sbin opencryptoki-libs.x86_64: W: dangling-relative-symlink /usr/lib64/pkcs11/methods ../../sbin => this is OK opencryptoki-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/opencryptoki/stdll/libpkcs11_tpm.so opencryptoki-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/opencryptoki/stdll/libpkcs11_sw.so opencryptoki-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/opencryptoki/libopencryptoki.so => explained in spec as required, libs should be dlopen-ed probably due license compatibility reasons this package is APPROVED New Package CVS Request ======================= Package Name: opencryptoki Short Description: Implementation of the PKCS#11 (Cryptoki) specification v2.11 Owners: michich sharkcz Branches: F-10 F-11 InitialCC: cvs done. Package imported and built. Thank you. opencryptoki-2.2.8-5.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/opencryptoki-2.2.8-5.fc11 opencryptoki-2.2.8-5.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/opencryptoki-2.2.8-5.fc10 opencryptoki-2.2.8-5.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. |