Bug 513454
| Summary: | Nodoka doesn't gray out checkboxes | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nanley Chery <nchery17> | ||||||||||
| Component: | gtk-nodoka-engine | Assignee: | Martin Sourada <martin.sourada> | ||||||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||||
| Severity: | medium | Docs Contact: | |||||||||||
| Priority: | low | ||||||||||||
| Version: | 11 | CC: | martin.sourada | ||||||||||
| Target Milestone: | --- | ||||||||||||
| Target Release: | --- | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | Linux | ||||||||||||
| Whiteboard: | |||||||||||||
| Fixed In Version: | 0.7.2-5.fc11 | Doc Type: | Bug Fix | ||||||||||
| Doc Text: | Story Points: | --- | |||||||||||
| Clone Of: | Environment: | ||||||||||||
| Last Closed: | 2009-08-15 08:07:48 UTC | Type: | --- | ||||||||||
| Regression: | --- | Mount Type: | --- | ||||||||||
| Documentation: | --- | CRM: | |||||||||||
| Verified Versions: | Category: | --- | |||||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||||
| Embargoed: | |||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 354900 [details]
Software Update MURRINE FANCY CANDY
That's because we set the checkboxes state according to the state of the parent widget, which in this case is not greyed out. I don't recall though why I chose that policy... So, this behaviour was introduced here: http://git.fedorahosted.org/git/nodoka?p=nodoka;a=commitdiff;h=a3232de044701bc2b0f7a895d3fb63f1556435de sadly, I didn't add an explanation of why I did it, but I guess it's probably because some check boxes stayed ungreyed even though the parent widget was greyed out. I'll put together a patch to force graying out of the checkboxes if they are themselves in insensitive state. Created attachment 354909 [details]
Patch to correctly grey out check boxes and radio buttons in TreeView
With this patch it should behave like expected. I'll build a package in next few minutes (I need to go through koji as I don't own x86_64, which you seem to have, so it might take a little longer).
Ok, build done, here you can download the packages to test http://koji.fedoraproject.org/koji/buildinfo?buildID=115712 Created attachment 354931 [details]
Software Update NODOKA (PATCHED)
Amazing work Martin. That was a very fast response and the patch works like a charm! I have the patched screenshot attached. Thanks!
gtk-nodoka-engine-0.7.2-5.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/gtk-nodoka-engine-0.7.2-5.fc11 gtk-nodoka-engine-0.7.2-5.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/gtk-nodoka-engine-0.7.2-5.fc10 gtk-nodoka-engine-0.7.2-5.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update gtk-nodoka-engine'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-7984 gtk-nodoka-engine-0.7.2-5.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update gtk-nodoka-engine'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-8019 gtk-nodoka-engine-0.7.2-5.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. gtk-nodoka-engine-0.7.2-5.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. |
Created attachment 354898 [details] Software Update NODOKA Description of problem: The Nodoka gtk theme does not display grayed out checkboxes while installing updates in gpk-update-viewer. Version-Release number of selected component (if applicable): 0.7.2 How reproducible: Always Steps to Reproduce: 1. Open gpk-update-viewer 2. Click "Install Updates" 3. Actual results: The checkboxes in the update viewer are not grayed out. Expected results: The checkboxes would be grayed out to show that selections can't be changed during the installation process. Additional info: During the upgrade process, switch to other themes for comparison.