Bug 514068
| Summary: | Review Request: parti-all - Software from the Parti project | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michal Schmidt <mschmidt> |
| Component: | Package Review | Assignee: | Matthew Miller <mattdm> |
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora, fedora-package-review, gholms, mattdm, notting, pahan |
| Target Milestone: | --- | Flags: | mattdm:
fedora-review?
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-11-11 09:52:39 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Michal Schmidt
2009-07-27 20:15:30 UTC
The reason for having the three components in a single source package is explained by the upstream author in README.xpra: Xpra is quite functional now, but Parti and wimpiggy are still under heavy development, so for now I'm still keeping everything together in one tree, to avoid version skew issues. Scratch build in Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=1541524 rpmlint says: parti.x86_64: W: dangling-relative-symlink /usr/share/doc/parti-0.0.6/NEWS ../wimpiggy-0.0.6/NEWS parti.x86_64: W: dangling-relative-symlink /usr/share/doc/parti-0.0.6/README ../wimpiggy-0.0.6/README parti.x86_64: W: dangling-relative-symlink /usr/share/doc/parti-0.0.6/COPYING ../wimpiggy-0.0.6/COPYING xpra.x86_64: W: dangling-relative-symlink /usr/share/doc/xpra-0.0.6/NEWS ../wimpiggy-0.0.6/NEWS xpra.x86_64: W: dangling-relative-symlink /usr/share/doc/xpra-0.0.6/COPYING ../wimpiggy-0.0.6/COPYING xpra.x86_64: W: dangling-relative-symlink /usr/share/doc/xpra-0.0.6/README ../wimpiggy-0.0.6/README 4 packages and 0 specfiles checked; 0 errors, 6 warnings. These symlinks should be OK. The files they point to are in the wimpiggy package on which both parti and xpra have a dependency. I can't do an official review, so here are some unofficial comments based on https://fedoraproject.org/wiki/Packaging/Guidelines and https://fedoraproject.org/wiki/Packaging:Python - In addition to the dangling symlinks you mention above, rpmlint complains about some bad executable permissions that need to be fixed. wimpiggy.x86_64: E: non-standard-executable-perm /usr/lib64/python2.6/site-packages/wimpiggy/lowlevel/bindings.so 0775 xpra.x86_64: E: non-standard-executable-perm /usr/lib64/python2.6/site-packages/xpra/wait_for_x_server.so 0775 - Documentation files should be marked as such with %doc in the spec file. - For a Python package you should BuildRequire python-devel instead of python. - You're missing the byte compilation step of %install specified by https://fedoraproject.org/wiki/Packaging:Python#Byte_Compiled_Files: %{__python} setup.py install -O1 --skip-build --root $RPM_BUILD_ROOT I hope that helps! Michal, still interested in working on this? I notice that there's been some work on a debian/ubuntu package at http://xpra.devloop.org.uk/ , and that many patches from that are in upstream hg. Since it looks like some good stuff, I think maybe we should build this from a version-control snapshot pending an updated official release? I am sorry for the delay. Garrett, thank you for your comments. Matthew, I am still interested in xpra, but I've been busy with other things. It would be better if someone else took care of the package. Would you like to take it? It's pretty cool and useful software. I need to be careful about adding more commitments to my plate, though. Anyone else up for it? *** This bug has been marked as a duplicate of bug 651591 *** |