Bug 514068 - Review Request: parti-all - Software from the Parti project
Summary: Review Request: parti-all - Software from the Parti project
Keywords:
Status: CLOSED DUPLICATE of bug 651591
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Matthew Miller
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-07-27 20:15 UTC by Michal Schmidt
Modified: 2010-11-11 09:52 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2010-11-11 09:52:39 UTC
Type: ---
Embargoed:
mattdm: fedora-review?


Attachments (Terms of Use)

Description Michal Schmidt 2009-07-27 20:15:30 UTC
Spec URL: http://michich.fedorapeople.org/parti/parti-all.spec
SRPM URL: http://michich.fedorapeople.org/parti/parti-all-0.0.6-1.fc11.src.rpm
Description:
The Parti project encompasses:
 - wimpiggy - library for writing window managers
 - parti - tabbing/tiling window manager
 - xpra - screen for X

Comment 1 Michal Schmidt 2009-07-28 10:10:01 UTC
The reason for having the three components in a single source package is explained by the upstream author in README.xpra:
  Xpra is quite functional now, but Parti and wimpiggy
  are still under heavy development, so for now I'm still keeping
  everything together in one tree, to avoid version skew issues.

Scratch build in Koji:
https://koji.fedoraproject.org/koji/taskinfo?taskID=1541524

rpmlint says:
parti.x86_64: W: dangling-relative-symlink /usr/share/doc/parti-0.0.6/NEWS ../wimpiggy-0.0.6/NEWS
parti.x86_64: W: dangling-relative-symlink /usr/share/doc/parti-0.0.6/README ../wimpiggy-0.0.6/README
parti.x86_64: W: dangling-relative-symlink /usr/share/doc/parti-0.0.6/COPYING ../wimpiggy-0.0.6/COPYING
xpra.x86_64: W: dangling-relative-symlink /usr/share/doc/xpra-0.0.6/NEWS ../wimpiggy-0.0.6/NEWS
xpra.x86_64: W: dangling-relative-symlink /usr/share/doc/xpra-0.0.6/COPYING ../wimpiggy-0.0.6/COPYING
xpra.x86_64: W: dangling-relative-symlink /usr/share/doc/xpra-0.0.6/README ../wimpiggy-0.0.6/README
4 packages and 0 specfiles checked; 0 errors, 6 warnings.

These symlinks should be OK. The files they point to are in the wimpiggy package on which both parti and xpra have a dependency.

Comment 2 Garrett Holmstrom 2010-01-13 04:49:21 UTC
I can't do an official review, so here are some unofficial comments based on https://fedoraproject.org/wiki/Packaging/Guidelines and https://fedoraproject.org/wiki/Packaging:Python

- In addition to the dangling symlinks you mention above, rpmlint complains about some bad executable permissions that need to be fixed.
wimpiggy.x86_64: E: non-standard-executable-perm /usr/lib64/python2.6/site-packages/wimpiggy/lowlevel/bindings.so 0775
xpra.x86_64: E: non-standard-executable-perm /usr/lib64/python2.6/site-packages/xpra/wait_for_x_server.so 0775

- Documentation files should be marked as such with %doc in the spec file.

- For a Python package you should BuildRequire python-devel instead of python.

- You're missing the byte compilation step of %install specified by https://fedoraproject.org/wiki/Packaging:Python#Byte_Compiled_Files:
%{__python} setup.py install -O1 --skip-build --root $RPM_BUILD_ROOT

I hope that helps!

Comment 3 Matthew Miller 2010-02-02 20:25:21 UTC
Michal, still interested in working on this?

I notice that there's been some work on a debian/ubuntu package at http://xpra.devloop.org.uk/ , and that many patches from that are in upstream hg.

Since it looks like some good stuff, I think maybe we should build this from a version-control snapshot pending an updated official release?

Comment 4 Michal Schmidt 2010-03-01 13:55:57 UTC
I am sorry for the delay.

Garrett,
thank you for your comments.

Matthew,
I am still interested in xpra, but I've been busy with other things. It would be better if someone else took care of the package. Would you like to take it?

Comment 5 Matthew Miller 2010-03-08 15:01:35 UTC
It's pretty cool and useful software. I need to be careful about adding more commitments to my plate, though. Anyone else up for it?

Comment 6 Michal Schmidt 2010-11-11 09:52:39 UTC

*** This bug has been marked as a duplicate of bug 651591 ***


Note You need to log in before you can comment on or make changes to this bug.