Bug 514936

Summary: mono-addins throws an exception when no addins are found
Product: [Fedora] Fedora Reporter: Christian Krause <chkr>
Component: mono-addinsAssignee: Christian Krause <chkr>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: 10CC: paul
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 0.3.1-3.fc10.3 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-08-27 22:52:35 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 484996    
Attachments:
Description Flags
patch to fix the problem (backported from newer versions of mono-addins) none

Description Christian Krause 2009-07-31 15:36:28 UTC 
Created attachment 355828 [details]
patch to fix the problem (backported from newer versions of mono-addins)

Description of problem:
This mono-addins version throws an exception when no addins found:

System.NullReferenceException: Object reference not set to an instance of an object
  at Mono.Addins.ExtensionNode.NotifyChildChanged () [0x00000] 
  at Mono.Addins.TreeNode.NotifyChildrenChanged () [0x00000] 
  at Mono.Addins.ExtensionTree.LoadExtensionElement (Mono.Addins.TreeNode tnode, System.String addin, Mono.Addins.Description.ExtensionNodeDescriptionCollection extension, System.Int32& curPos, Mono.Addins.BaseCondition parentCondition, Boolean inComplextCondition, System.Collections.ArrayList addedNodes) [0x00000] 
  at Mono.Addins.ExtensionTree.LoadExtension (System.String addin, Mono.Addins.Description.Extension extension, System.Collections.ArrayList addedNodes) [0x00000] 
  at Mono.Addins.ExtensionContext.LoadModuleExtensionNodes (Mono.Addins.Description.Extension extension, System.String addinId, Mono.Addins.Description.ExtensionNodeSet nset, System.Collections.ArrayList loadedNodes) [0x00000] 
  at Mono.Addins.ExtensionContext.LoadExtensions (System.String requestedExtensionPath) [0x00000] 
  at Mono.Addins.TreeNode.get_Children () [0x00000] 
  at Mono.Addins.ExtensionNode.get_ChildNodes () [0x00000] 


Version-Release number of selected component (if applicable):
mono-addins-0.3.1-2.2.fc10.i386


How reproducible:
100%


Steps to Reproduce:
1. install f-spot which uses Mono.Addins from the system: https://koji.fedoraproject.org/koji/buildinfo?buildID=125023
2. start f-spot in a terminal
  
Actual results:
exception thrown (see above)

Expected results:
no exception

Additional info:
- problem is fixed in newer releases of mono-addins
- backported isolated fix is attached
Comment 1 Paul F. Johnson 2009-08-21 22:00:38 UTC 
Sorry - for some reason this hadn't come up on my email!

I'll get onto this ASAP. Fix should be in within 24 hours.

Paul
Comment 2 Christian Krause 2009-08-21 23:49:46 UTC 
(In reply to comment #1)
> Sorry - for some reason this hadn't come up on my email!
> I'll get onto this ASAP. Fix should be in within 24 hours.

No problem. If it is OK with you it would be great if you could grant me commit permissions for mono-addins as well. I could then fix small bugs like this just by myself. I think having a co-maintainer for this package would be helpful.

Looking forward to hear back from you.
Comment 3 Fedora Update System 2009-08-24 20:13:49 UTC 
mono-addins-0.3.1-3.fc10.3 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/mono-addins-0.3.1-3.fc10.3
Comment 4 Fedora Update System 2009-08-25 22:15:08 UTC 
mono-addins-0.3.1-3.fc10.3 has been pushed to the Fedora 10 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update mono-addins'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-9014
Comment 5 Fedora Update System 2009-08-27 22:52:31 UTC 
mono-addins-0.3.1-3.fc10.3 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.