Bug 515053
| Summary: | Review Request: sugar-getiabooks - Internet Archive Books receiver for Sugar | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabian Affolter <mail> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | j:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 3-2.fc11 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-12-07 07:34:06 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 462625 | ||
|
Description
Fabian Affolter
2009-08-01 11:43:44 UTC
I was going to review this, but then I noticed that version 3 is out. Did you want to update this package? Here are the updated files Spec URL: http://fab.fedorapeople.org/packages/XO/sugar-getiabooks.spec SRPM URL: http://fab.fedorapeople.org/packages/XO/sugar-getiabooks-3-1.fc11.src.rpm Hmm, it's been longer than I thought since I looked at this.
Builds fine; rpmlint just says
sugar-getiabooks.noarch: W: non-standard-group Sugar/Activities
which is OK; I'm not sure why rpmlint still complains about this as we don't particularly care what goes in group anyway.
The NEWS file seems to be present twice in the final package.
Nothing seems to own /usr/share/sugar/activities. (Well, etoys owns it, but that's not in the dependency chain.) I think this is probably a bug in sugar, but absent that it's a bug in the guidelines and this package should own %{sugaractivitydir}. I've inquired on the fedora-packaging list.
* source files match upstream. sha256sum:
fa25987241db043235b132c2c12aba56b1865947e35180990ea32c431c326fa4
GetIABooks-3.tar.bz2
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK (though it's no longer required at all).
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint has acceptable complaints.
* final provides and requires are sane:
sugar-getiabooks = 3-1.fc12
=
/usr/bin/env
sugar
(python is pulled in indirectly via sugar)
? nothing seems to own %{sugaractivitydir}.
* doesn't own any directories it shouldn't.
X NEWS seems to be duplicated.
* file permissions are appropriate.
* no generically named files
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
Turns out that this package is doing the right thing with respect to %{sugaractivitydir}; the main sugar package will be fixed to own it. That just leaves the NEWS file, which should be easy to either fix up or justify.
Thanks for the review Jason. The issue with the NEWS file is fixed now. Here are the updated files: Spec URL: http://fab.fedorapeople.org/packages/XO/sugar-getiabooks.spec SRPM URL: http://fab.fedorapeople.org/packages/XO/sugar-getiabooks-3-2.fc11.src.rpm Note that the spec above doesn't match what's in the srpm above; the latter elicits an incoherent-version-in-changelog complaint from rpm. I guess you fixed that in the separate spec. Please let me know that you're doing things like that to avoid confusion. Anyway, aside from that rpmlint complaint which you've already fixed, this looks good. APPROVED Sorry, it seams that I fixed the incoherent-version-in-changelog issue after the rpm build process and uploaded the stuff before make a new srpm. Thanks for the hint. New Package CVS Request ======================= Package Name: sugar-getiabooks Short Description: Internet Archive Books receiver for Sugar Owners: fab Branches: F-11 F-12 InitialCC: CVS done. sugar-getiabooks-3-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/sugar-getiabooks-3-2.fc12 sugar-getiabooks-3-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/sugar-getiabooks-3-2.fc11 sugar-getiabooks-3-2.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update sugar-getiabooks'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2009-11963 sugar-getiabooks-3-2.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update sugar-getiabooks'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-11999 sugar-getiabooks-3-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. sugar-getiabooks-3-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. |