Bug 516271
Summary: | Review Request: perl-Curses-UI - Curses based OO user interface framework | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | David Hannequin <david.hannequin> |
Component: | Package Review | Assignee: | Iain Arnell <iarnell> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | emmanuel, fedora-package-review, iarnell, notting, panemade |
Target Milestone: | --- | Flags: | iarnell:
fedora-review+
dennis: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | 0.9607-2.fc11 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-10-29 02:53:46 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 516280 |
Description
David Hannequin
2009-08-07 17:47:14 UTC
Package fails to build in mock. You need to add BuildRequires for (at least) Test::Simple, Test::More, and Test::Pod. Scratch Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1590880 Hi, Spec URL: http://hvad.cfppa-cibeins.com/perl-modules/perl-Curses-UI/perl-Curses-UI.spec SRPM URL: http://hvad.cfppa-cibeins.com/perl-modules/perl-Curses-UI/perl-Curses-UI-0.9607-2.fc10.src.rpm Can you give me log url ? Best regard You can make tests yourself using mock locally (see https://fedoraproject.org/wiki/Extras/MockTricks), and once you're happy that the build works locally in mock, you can also request your own koji scratch build (e.g. koji build --scratch dist-f12 /path/to/perl-Some-Module-xx.yy-zz.src.rpm). But all looks good with this revision (log url is about 20 lines down). + source files match upstream (sha1). f7a506f6d62fa58028084d57c85ef78e59486623 Curses-UI-0.9607.tar.gz f7a506f6d62fa58028084d57c85ef78e59486623 ./Curses-UI-0.9607.tar.gz + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + summary is OK. + description is OK. + dist tag is present. + build root is OK. + license field matches the actual license. GPL+ or Artistic + license is open source-compatible. + license text not included upstream. + latest version is being packaged. + BuildRequires are proper. + compiler flags are appropriate. + %clean is present. + package builds in mock http://koji.fedoraproject.org/koji/taskinfo?taskID=1612394 + package installs properly. + rpmlint has no complaints: perl-Curses-UI.noarch: I: checking perl-Curses-UI.src: I: checking 2 packages and 0 specfiles checked; 0 errors, 0 warnings. + final provides and requires are sane: perl(Curses::UI) = 0.9607 perl(Curses::UI::Buttonbox) = 1.10 perl(Curses::UI::Calendar) = 1.10 perl(Curses::UI::Checkbox) = 1.11 perl(Curses::UI::Color) = 0.01 perl(Curses::UI::Common) = 1.10 perl(Curses::UI::Container) = 1.11 perl(Curses::UI::ContainerWidget) = 1.10 perl(Curses::UI::Dialog::Basic) = 1.10 perl(Curses::UI::Dialog::Calendar) = 1.10 perl(Curses::UI::Dialog::Dirbrowser) = 1.0 perl(Curses::UI::Dialog::Error) = 1.10 perl(Curses::UI::Dialog::Filebrowser) = 1.10 perl(Curses::UI::Dialog::Progress) = 1.10 perl(Curses::UI::Dialog::Question) = 1.00 perl(Curses::UI::Dialog::Status) = 1.10 perl(Curses::UI::Label) = 1.11 perl(Curses::UI::Language) perl(Curses::UI::Language::chinese) perl(Curses::UI::Language::czech) perl(Curses::UI::Language::dutch) perl(Curses::UI::Language::english) perl(Curses::UI::Language::french) perl(Curses::UI::Language::german) perl(Curses::UI::Language::italian) perl(Curses::UI::Language::japanese) perl(Curses::UI::Language::norwegian) perl(Curses::UI::Language::polish) perl(Curses::UI::Language::portuguese) perl(Curses::UI::Language::russian) perl(Curses::UI::Language::slovak) perl(Curses::UI::Language::spanish) perl(Curses::UI::Language::turkish) perl(Curses::UI::Listbox) = 1.3 perl(Curses::UI::MenuListbox) = 1.10 perl(Curses::UI::Menubar) = 1.10 perl(Curses::UI::Notebook) = 1.0001 perl(Curses::UI::PasswordEntry) = 1.10 perl(Curses::UI::Popupmenu) = 1.10 perl(Curses::UI::PopupmenuListbox) = 1.0011 perl(Curses::UI::Progressbar) = 1.10 perl(Curses::UI::Radiobuttonbox) = 1.10 perl(Curses::UI::SearchEntry) = 1.10 perl(Curses::UI::Searchable) = 1.10 perl(Curses::UI::TextEditor) = 1.5 perl(Curses::UI::TextEntry) = 1.10 perl(Curses::UI::TextViewer) = 1.10 perl(Curses::UI::Widget) = 1.12 perl(Curses::UI::Window) = 1.10 perl-Curses-UI = 0.9607-2.fc12 = perl >= 1:5 perl(:MODULE_COMPAT_5.10.0) perl(Carp) perl(Curses) perl(Curses::UI::Color) perl(Curses::UI::Common) perl(Curses::UI::Container) perl(Curses::UI::Dialog::Basic) perl(Curses::UI::Label) perl(Curses::UI::Language) perl(Curses::UI::Listbox) perl(Curses::UI::Searchable) perl(Curses::UI::TextEditor) perl(Curses::UI::TextEntry) perl(Curses::UI::TextViewer) perl(Curses::UI::Widget) perl(Curses::UI::Window) perl(Cwd) perl(Exporter) perl(FileHandle) perl(Term::ReadKey) perl(base) perl(strict) perl(vars) perl(warnings) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(VersionedDependencies) <= 3.0.3-1 rpmlib(PayloadIsXz) <= 5.2-1 + %check is present and all tests pass. t/99misc.t .............. ok All tests successful. Files=14, Tests=169, 4 wallclock secs ( 0.11 usr 0.01 sys + 3.38 cusr 0.10 csys = 3.60 CPU) Result: PASS + no shared libraries are added to the regular linker search paths. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + no generically named files + code, not content. + documentation is small, so no -doc subpackage is necessary. + %docs are not necessary for the proper functioning of the package. APPROVED. New Package CVS Request ======================= Package Name: perl-Curses-UI Short Description: Curses based OO user interface framework Owners: hvad Branches: F-10 F-11 InitialCC: hvad perl-sig (In reply to comment #4) > > New Package CVS Request The fedora‑cvs flag isn't set so I doubt the CVS admins are going to see this bug. Whoops. Set fedora-cvs- instead of fedora-cvs? David, don't set fedora-cvs to '+'. The cvs admins should do that after creating the module. CVS Done No need to add an owner to the InitalCC list any reason for not building this package yet? perl-Curses-UI-0.9607-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/perl-Curses-UI-0.9607-2.fc10 perl-Curses-UI-0.9607-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-Curses-UI-0.9607-2.fc11 perl-Curses-UI-0.9607-2.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-Curses-UI'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-9818 perl-Curses-UI-0.9607-2.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-Curses-UI'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-9870 perl-Curses-UI-0.9607-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. perl-Curses-UI-0.9607-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. |