Bug 516280 - Review Request: perl-Config-Model-CursesUI - Curses interface to edit config data
Summary: Review Request: perl-Config-Model-CursesUI - Curses interface to edit config ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 515079 516271
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-08-07 19:30 UTC by David Hannequin
Modified: 2010-03-13 02:28 UTC (History)
3 users (show)

Fixed In Version: perl-Config-Model-CursesUI-1.103-3.fc12
Clone Of:
Environment:
Last Closed: 2009-12-01 04:30:17 UTC
Type: ---
Embargoed:
panemade: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description David Hannequin 2009-08-07 19:30:11 UTC
Spec URL: http://hvad.cfppa-cibeins.com/perl-modules/perl-Config-Model-CursesUI/perl-Config-Model-CursesUI.spec
SRPM URL: http://hvad.cfppa-cibeins.com/perl-modules/perl-Config-Model-CursesUI/perl-Config-Model-CursesUI-1.103-1.fc10.src.rpm
Description: This class provides a Curses::UI interface to configuration data managed by Config::Model

Comment 1 Parag AN(पराग) 2009-09-14 08:24:12 UTC
build failed with
DEBUG util.py:256:  No Package Found for perl(Curses::UI) >= 0.9606

Comment 2 David Hannequin 2009-09-14 19:25:06 UTC
Hi,

You need package https://bugzilla.redhat.com/show_bug.cgi?id=516271. 

best regard

Comment 3 Parag AN(पराग) 2009-09-17 05:51:02 UTC
Can you build that package?

Comment 4 David Hannequin 2009-10-07 20:20:09 UTC
It 's build.

Comment 5 Parag AN(पराग) 2009-10-09 05:47:49 UTC
build failed at http://koji.fedoraproject.org/koji/taskinfo?taskID=1737447

Comment 6 Parag AN(पराग) 2009-10-21 06:37:10 UTC
Add BR: perl(Test::More)

See http://koji.fedoraproject.org/koji/getfile?taskID=1758809&name=build.log

Comment 8 Parag AN(पराग) 2009-11-05 05:50:39 UTC
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1789156
+ rpmlint output for SRPM and for RPM.
perl-Config-Model-CursesUI.noarch: W: invalid-license LGPL
==> Fix this
+ source files match upstream url(sha1sum)
d79c4a2ad400efa725806f3344495b86bcda9294  Config-Model-CursesUI-1.103.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=1, Tests=3,  1 wallclock secs ( 0.02 usr  0.01 sys +  0.24 cusr  0.02 csys =  0.29 CPU)
+ Package  perl-Config-Model-CursesUI-1.103-2.fc12.noarch=>
Provides: perl(Config::Model::CursesUI) = 1.103
Requires: perl(Carp) perl(Config::Model::Exception) perl(Config::Model::ObjTreeScanner) perl(Curses::UI) perl(Exception::Class) perl(Exporter) perl(strict) perl(vars) perl(warnings)
+ Not a GUI application

Suggestions:
1) Correct license is LGPLv2+ so change it before you import this package in cvs.

Comment 11 David Hannequin 2009-11-10 08:41:51 UTC
New Package CVS Request
=======================
Package Name: perl-Config-Model-CursesUI
Short Description: This class provides a Curses::UI interface to configuration data managed by Config::Model 
Owners: hvad
Branches: F-10 F-11 F-12 
InitialCC: perl-sig

Comment 12 Kevin Fenzi 2009-11-11 03:48:34 UTC
cvs done.

Comment 13 Fedora Update System 2009-11-11 18:54:25 UTC
perl-Config-Model-CursesUI-1.103-3.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/perl-Config-Model-CursesUI-1.103-3.fc10

Comment 14 Fedora Update System 2009-11-11 19:24:03 UTC
perl-Config-Model-CursesUI-1.103-3.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/perl-Config-Model-CursesUI-1.103-3.fc12

Comment 15 Fedora Update System 2009-11-12 20:47:42 UTC
perl-Config-Model-CursesUI-1.103-3.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/perl-Config-Model-CursesUI-1.103-3.fc11

Comment 16 Fedora Update System 2009-11-13 02:23:45 UTC
perl-Config-Model-CursesUI-1.103-3.fc10 has been pushed to the Fedora 10 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update perl-Config-Model-CursesUI'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-11450

Comment 17 Fedora Update System 2009-11-13 02:36:11 UTC
perl-Config-Model-CursesUI-1.103-3.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update perl-Config-Model-CursesUI'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2009-11479

Comment 18 Fedora Update System 2009-11-16 07:34:31 UTC
perl-Config-Model-CursesUI-1.103-3.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update perl-Config-Model-CursesUI'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-11591

Comment 19 Fedora Update System 2009-12-01 04:30:11 UTC
perl-Config-Model-CursesUI-1.103-3.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 20 Fedora Update System 2009-12-11 18:26:22 UTC
perl-Config-Model-CursesUI-1.103-3.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 21 Fedora Update System 2010-03-13 02:28:16 UTC
perl-Config-Model-CursesUI-1.103-3.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.