Bug 516533
| Summary: | Review Request: globus-gatekeeper - Globus Toolkit - Globus Gatekeeper | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mattias Ellert <mattias.ellert> |
| Component: | Package Review | Assignee: | Steve Traylen <steve.traylen> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, steve.traylen |
| Target Milestone: | --- | Flags: | steve.traylen:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 5.0-1.el5 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-10-21 00:35:05 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 516536 | ||
|
Description
Mattias Ellert
2009-08-10 11:03:23 UTC
Review of globus-gatekeeper: Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1752463 YES: rpmlint. rpmlint globus-gatekeeper.spec ../SRPMS/globus-gatekeeper-5.0-1.fc11.src.rpm ../RPMS/x86_64/globus-gatekeeper-* 3 packages and 1 specfiles checked; 0 errors, 0 warnings. clean. YES: Package name YES: Spec file name. YES: Follows globus guidelines. YES: YES ASL2.0 YES: LICESNSE file included. YES: Spec in english YES: Spec is legible. YES: Source matches. $ diff -r --brief globus_gatekeeper-5.0 ~/globus/src/gt4.2.1-all-source-installer/source-trees/gatekeeper/source/ Only in globus_gatekeeper-5.0: GLOBUS_LICENSE $ diff -r --brief gt4.2.1-all-source-installer/source-trees/gatekeeper/setup ~/rpmbuild/SOURCES/globus_gatekeeper_setup-2.2 Only in /home/steve/rpmbuild/SOURCES/globus_gatekeeper_setup-2.2: GLOBUS_LICENSE which are expected. YES: Builds as per koji above. YES: Builds on all archs as per koji above. YES: BuildRequires are sensible. YES: No locales present. YES: ldconfig not needed. YES: No system libs. YES: It owns its own directories. YES: Permissions are correct. YES: %clean rm %buildroot YES: consistant use of macros. YES: Contains code. YES: No large documents. YES: %doc not needed at runtime. YES: no devel pcakge. YES: No static files. YES: No .la files are present. YES: No gui YES: does not own files/directories owned elsewhere. YES: %install does a rm %buildroot YES: utf8. Looks good and even starts. APPROVED Steve. New Package CVS Request ======================= Package Name: globus-gatekeeper Short Description: Globus Toolkit - Globus Gatekeeper Owners: ellert Branches: F-11 F-12 EL-4 EL-5 InitialCC: cvs done. globus-gatekeeper-5.0-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/globus-gatekeeper-5.0-1.fc12 globus-gatekeeper-5.0-1.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/globus-gatekeeper-5.0-1.el5 globus-gatekeeper-5.0-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/globus-gatekeeper-5.0-1.fc11 globus-gatekeeper-5.0-1.el4 has been submitted as an update for Fedora EPEL 4. http://admin.fedoraproject.org/updates/globus-gatekeeper-5.0-1.el4 globus-gram-client-7.2-1.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/globus-gram-client-7.2-1.el5 globus-gram-client-7.2-1.el4 has been submitted as an update for Fedora EPEL 4. http://admin.fedoraproject.org/updates/globus-gram-client-7.2-1.el4 globus-gatekeeper-5.0-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. I don't know that it matters but according http://fedoraproject.org/wiki/PackageMaintainers/NewPackageProcess new packages should be closed with CLOSED -> NEXTRELEASE (In reply to comment #11) > I don't know that it matters but according > > http://fedoraproject.org/wiki/PackageMaintainers/NewPackageProcess > > new packages should be closed with CLOSED -> NEXTRELEASE The bug was automatically closed by Bodhi when the package was pushed to stable. The Bodhi request was tagged as "newpackage", so Bodhi should be able to close the bug the right way. And it looks like my previous review request bugs that were automatically closed by Bodhi were closed with NEXTRELEASE. So either this is a recent bug introduced in Bodhi, or a change in policy that has been implemented in Bodhi but that hasn't been properly documented. globus-gatekeeper-5.0-1.el4 has been pushed to the Fedora EPEL 4 stable repository. If problems still persist, please make note of it in this bug report. globus-gatekeeper-5.0-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. |