Bug 518450
| Summary: | Review Request: moblin-panel-status - Moblin Panel for Social Network Status | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Peter Robinson <pbrobinson> |
| Component: | Package Review | Assignee: | Michel Lind <michel> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, michel, notting |
| Target Milestone: | --- | Flags: | michel:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-08-28 17:04:55 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 513452 | ||
| Bug Blocks: | 506446 | ||
|
Description
Peter Robinson
2009-08-20 13:07:19 UTC
Some minor rpmlint error -- use Emacs M-q to fix? moblin-panel-status.i686: E: description-line-too-long The Moblin mutter panel for managing of social networks and your current status. 1 packages and 0 specfiles checked; 1 errors, 0 warnings. SRPM's rpmlint is clean. The only other problem is with the license file (see note within the review).
MUST
• package name: OK
• spec file name: OK
• package guideline-compliant: OK
• license complies with guidelines: OK
• license field accurate:
• license file not deleted
Note: bundled license file is inaccurate (LGPL, not GPL). Contact upstream developers? The source file headers all refer to GPLv2+ so I'm assuming that's the correct one
• spec in US English: OK
• spec legible: OK
• source matches upstream: OK
• builds under >= 1 archs, others excluded: OK (Koji)
• build dependencies complete: OK (Koji)
• locales handled using %find_lang, no %{_datadir}/locale: OK
• own all directories: OK
• no dupes in %files: OK
• permission: OK
• %clean RPM_BUILD_ROOTL OK
• macros used consistently: OK
• Package contains code: OK
• clean buildroot before install: OK
• filenames UTF-8: OK
SHOULD
• if license text missing, ask upstream to include it
Not missing in this case, but inaccurate (worse?)
• package build in mock on all architectures: OK
• package functioned as described
Not tested yet
• scriplets are sane: OK
• require package not files: OK
> Note: bundled license file is inaccurate (LGPL, not GPL). Contact upstream
> developers? The source file headers all refer to GPLv2+ so I'm assuming that's
> the correct one
I will query upstream to get them to update the COPYING file but the package was split out of mutter-moblin and its GPLv2 so it will be the same license.
Let's move on while waiting on that -- just make a note to fix it once we hear back from upstream. After all, it is valid to choose to revert any LGPL package under the corresponding GPL version. APPROVED Thanks Michael. I'll add a note to the spec file. New Package CVS Request ======================= Package Name: moblin-panel-status Short Description: Moblin Panel for Social Network Status Owners: pbrobinson Branches: F-11 InitialCC: cvs done. Imported into CVS. Has build issues at the moment as the telepathy-mission-control has broken anerley. |