Bug 518489

Summary: Review Request: plexus-containers - Containers for Plexus
Product: [Fedora] Fedora Reporter: Andrew Overholt <overholt>
Component: Package ReviewAssignee: Alexander Kurtakov <akurtako>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: akurtako, fedora-package-review, notting
Target Milestone: ---Flags: akurtako: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-08-20 17:19:41 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Description Andrew Overholt 2009-08-20 15:28:42 UTC
Spec URL: http://overholt.fedorapeople.org/plexus-containers.spec
SRPM URL: http://overholt.fedorapeople.org/plexus-containers-1.0-0.1.a34.7.fc11.src.rpm

Description: 
The Plexus project seeks to create end-to-end developer tools for
writing applications. At the core is the container, which can be
embedded or for a full scale application server. There are many
reusable components for hibernate, form processing, jndi, i18n,
velocity, etc. Plexus also includes an application server which
is like a J2EE application server, without all the baggage.

Comment 1 Alexander Kurtakov 2009-08-20 16:46:57 UTC
Formal review:

OK: rpmlint must be run on every package. Rpmlint gives the following warnings:
plexus-containers.noarch: W: no-documentation
plexus-containers.noarch: W: non-conffile-in-etc /etc/maven/fragments/plexus-containers
plexus-containers-component-annotations.noarch: W: no-documentation
plexus-containers-container-default.noarch: W: no-documentation

It would be good if we can fix them but it's not a blocker.

OK: The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines .
OK: The License field in the package spec file must match the actual license. 
OK: Instructions for fetching
OK: The package MUST successfully compile 
OK: All build dependencies must be listed in BuildRequires
OK: A package must own all directories that it creates. 
OK: A Fedora package must not list a file more than once in the spec file's %files listings.
OK: Permissions on files must be set properly. 
OK: Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [15]
OK: Each package must consistently use macros. [16]
OK: The package must contain code, or permissable content. [17]
OK: Large documentation files must go in a -doc subpackage.
OK: If a package includes something as %doc, it must not affect the runtime of the application. 
OK: Packages must not own files or directories already owned by other packages. OK: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). 
OK: All filenames in rpm packages must be valid UTF-8. [26]

This package is APPROVED.

Comment 2 Andrew Overholt 2009-08-20 17:19:41 UTC
Built:  http://koji.fedoraproject.org/koji/taskinfo?taskID=1618018