Bug 518539
| Summary: | Review Request: xblas - Extra Precise Basic Linear Algebra Subroutines | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tom "spot" Callaway <tcallawa> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, jamatos, notting |
| Target Milestone: | --- | Flags: | jamatos:
fedora-review+
tcallawa: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 1.0.248-2.fc10 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-08-25 04:28:10 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Tom "spot" Callaway
2009-08-20 19:57:52 UTC
Scratch Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1618494 Just curious, why the call to autoconf at the end of the prep section? After a general analysis of the spec it looks like it was taken from a schoolbook. ;-) Because the patch for shared support applies to configure.ac, rather than configure, I need to rerun autoconf. As to the schoolbook nature of the spec, that's a good thing, right? :) Yes, I noticed that after reading the documentation. Sorry. :-) Being an assistant professor I can say that the schoolbook nature of the spec is a bonus. :-) Expect a full review soon. Review: The source package is the same as upstream. The license is correct (BSD) and appropriate for Fedora. This is even more appropriate in the case since the copyright comes from Berkeley. :-) The package build in the supported Fedora architectures. (see #2) Build on F11 and rawhide. The package follows the packaging guidelines. The package is _approved_. PS: One small detail, I noticed that you have placed README.devel in the devel sub-package, after reading it I am not sure how useful the file is. I think that the content is useless for any developer, but I leave to you the final decision. The README file on the other hand is really helpful and in a sense it belongs more to devel than to the main package. If you think that I am being pedantic in the last argument (README) then I agree with you and you are free to ignore me. New Package CVS Request ======================= Package Name: xblas Short Description: Extra Precise Basic Linear Algebra Subroutines Owners: spot Branches: F-10 F-11 devel InitialCC: ... and it's done. Thanks for the review (I did make that minor change). xblas-1.0.248-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/xblas-1.0.248-2.fc10 xblas-1.0.248-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/xblas-1.0.248-2.fc11 xblas-1.0.248-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. xblas-1.0.248-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. |