Bug 520501
| Summary: | Review Request: maven-archiver - Maven Archiver | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Alexander Kurtakov <akurtako> |
| Component: | Package Review | Assignee: | Andrew Overholt <overholt> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, overholt |
| Target Milestone: | --- | Flags: | overholt:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-09-01 08:10:08 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 429551 | ||
|
Description
Alexander Kurtakov
2009-08-31 19:46:10 UTC
This is a full review request. Pre-review was #500271 . - naming and licensing fine
X please wrap lines 47, 104, and 108 at <= 80 characters
X please add a changelog entry
X please only own the fragment %{name} and specific pom (JPP-maven-archiver.pom)
X please drop the with_maven/without_maven stuff at the top of the .spec
- sources fine (I get no differences between my export and the one in the tarball)
? should we make the maven2 R/BR >= 2.0.8?
? let's make the description "The Maven Archiver is used by other Maven plugins to handle packaging."
- cleaning done appropriately
- builds fine
- macros good
- rpmlint output is fine:
$ rpmlint maven-archiver-2.2-1.fc11.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint maven-archiver-2.2-1.fc11.noarch.rpm
maven-archiver.noarch: W: no-documentation
maven-archiver.noarch: W: non-conffile-in-etc /etc/maven/fragments/maven-archiver
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
$ rpmlint maven-archiver-javadoc-2.2-1.fc11.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
(In reply to comment #2) > - naming and licensing fine > X please wrap lines 47, 104, and 108 at <= 80 characters Done. > X please add a changelog entry Done. > X please only own the fragment %{name} and specific pom > (JPP-maven-archiver.pom) Done > X please drop the with_maven/without_maven stuff at the top of the .spec Done > - sources fine (I get no differences between my export and the one in the > tarball) > ? should we make the maven2 R/BR >= 2.0.8? Done > ? let's make the description "The Maven Archiver is used by other Maven plugins > to handle packaging." Done. > - cleaning done appropriately > - builds fine > - macros good > - rpmlint output is fine: New sources: Spec URL: http://akurtakov.fedorapeople.org/maven-archiver.spec SRPM URL: http://akurtakov.fedorapeople.org/maven-archiver-2.2-2.fc11.src.rpm Thanks, approved. New Package CVS Request ======================= Package Name: maven-archiver Short Description: The Maven Archiver is used by other Maven plugins to handle packaging. Owners: overholt, akurtakov Branches: InitialCC: CVS done. Build in rawhide. http://koji.fedoraproject.org/koji/buildinfo?buildID=130085 |