Bug 520864

Summary: libvirt is using untrusted 'info vcpus' PID data for already running VM after libvirtd restart
Product: [Fedora] Fedora Reporter: Daniel Berrangé <berrange>
Component: libvirtAssignee: Daniel Berrangé <berrange>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: berrange, clalance, crobinso, itamar, markmc, veillard, virt-maint
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-09-15 10:25:32 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 498969    

Description Daniel Berrangé 2009-09-02 18:00:15 UTC 
Description of problem:
Once the guest has started executing, libvirt must be careful about trusting data from the QEMU monitor. During initial VM startup it is safe to trust data up until 'cont' has been issued to start the vCPUs.

After a libvirtd restart though, the QEMU driver is calling 'info vcpus' to get the vCPU<->thread PID  mapping data. It should not do this. THis data should be stored in the persistent state file during initial VM startup, and never queried thereafter.

Version-Release number of selected component (if applicable):
0.7.0

How reproducible:
N/a

Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:
Comment 1 Daniel Berrangé 2009-09-11 15:28:42 UTC 
http://www.redhat.com/archives/libvir-list/2009-September/msg00413.html
Comment 2 Mark McLoughlin 2009-09-15 10:25:32 UTC 
* Mon Sep 14 2009 Mark McLoughlin <markmc> - 0.7.1-0.2.gitfac3f4c
- Update to newer snapshot of 0.7.1
- Stop libvirt using untrusted 'info vcpus' PID data (#520864)
- Support relabelling of USB and PCI devices
- Enable multipath storage support
- Restart libvirtd upon RPM upgrade
Comment 3 Daniel Berrangé 2009-09-15 10:47:54 UTC 
Merged upstream too

http://libvirt.org/git/?p=libvirt.git;a=commit;h=f2ad7824aa16a089c7e25736d30978abb5ecf18c