Bug 521063

Summary: Extra parameters required for GetDevices
Product: [Fedora] Fedora Reporter: Tim Waugh <twaugh>
Component: system-config-printerAssignee: Tim Waugh <twaugh>
Status: CLOSED UPSTREAM QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: jpopelka, mkasik, twaugh
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-09-03 16:35:43 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 473302    

Description Tim Waugh 2009-09-03 12:21:57 UTC 
Description of problem:
Unfortunately while working on this issue:
  https://fedorahosted.org/system-config-printer/ticket/14

I have realised that we don't get to pass through some optional parameters when using PolicyKit.

The available optional parameters for CUPS-Get-Devices are:

1. limit, an integer, specifying the maximum number of devices to return
2. include-schemes, a list of strings specifying the inclusion list for returned device URI schemes
3. exclude-schemes, a list of strings specifying the exclusion list for returned device URI schemes

The include-schemes and exclude-schemes parameters are mutually exclusive.

There are currently no others.

Version-Release number of selected component (if applicable):
cups-pk-helper-0.0.4-7.fc12.x86_64

Additional info:
I don't think it's possible to have optional parameters with D-Bus so we need some way to signal whether the parameters should be used or not -- perhaps just '0' for no limit and empty list for the other two.  In other words, include-schemes would only be used if non-empty, otherwise exclude-schemes.

This is an API break so will need either a new interface name (can we do that?) or new policy mechanism method name.
Comment 1 Tim Waugh 2009-09-03 12:23:41 UTC 
...and of course I'm wrong, the D-Bus API supports this already (yay!), just that system-config-printer's cupspk doesn't yet.
Comment 2 Tim Waugh 2009-09-03 16:35:43 UTC 
Fixed upstream.