Bug 521063 - Extra parameters required for GetDevices
Extra parameters required for GetDevices
Status: CLOSED UPSTREAM
Product: Fedora
Classification: Fedora
Component: system-config-printer (Show other bugs)
rawhide
All Linux
low Severity medium
: ---
: ---
Assigned To: Tim Waugh
Fedora Extras Quality Assurance
:
Depends On:
Blocks: F12Target
  Show dependency treegraph
 
Reported: 2009-09-03 08:21 EDT by Tim Waugh
Modified: 2009-09-03 12:35 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-09-03 12:35:43 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:


Attachments (Terms of Use)

  None (edit)
Description Tim Waugh 2009-09-03 08:21:57 EDT
Description of problem:
Unfortunately while working on this issue:
  https://fedorahosted.org/system-config-printer/ticket/14

I have realised that we don't get to pass through some optional parameters when using PolicyKit.

The available optional parameters for CUPS-Get-Devices are:

1. limit, an integer, specifying the maximum number of devices to return
2. include-schemes, a list of strings specifying the inclusion list for returned device URI schemes
3. exclude-schemes, a list of strings specifying the exclusion list for returned device URI schemes

The include-schemes and exclude-schemes parameters are mutually exclusive.

There are currently no others.

Version-Release number of selected component (if applicable):
cups-pk-helper-0.0.4-7.fc12.x86_64

Additional info:
I don't think it's possible to have optional parameters with D-Bus so we need some way to signal whether the parameters should be used or not -- perhaps just '0' for no limit and empty list for the other two.  In other words, include-schemes would only be used if non-empty, otherwise exclude-schemes.

This is an API break so will need either a new interface name (can we do that?) or new policy mechanism method name.
Comment 1 Tim Waugh 2009-09-03 08:23:41 EDT
...and of course I'm wrong, the D-Bus API supports this already (yay!), just that system-config-printer's cupspk doesn't yet.
Comment 2 Tim Waugh 2009-09-03 12:35:43 EDT
Fixed upstream.

Note You need to log in before you can comment on or make changes to this bug.