Bug 521240
| Summary: | Review Request: maven-plugin-bundle - Maven Bundle Plugin | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Alexander Kurtakov <akurtako> |
| Component: | Package Review | Assignee: | Andrew Overholt <overholt> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, overholt |
| Target Milestone: | --- | Flags: | overholt:
fedora-review+
dennis: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-09-10 07:49:46 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 486360 | ||
|
Description
Alexander Kurtakov
2009-09-04 13:40:53 UTC
X won't build (needs additional BRs -- see http://overholt.fedorapeople.org/maven-plugin-bundle.spec) X probably needs Requires fixed up to match or be similar to BRs X the last sentence of the description should be removed. X files good except for %{_javadir} line ... %{_javadir}/*, perhaps? - sources ok (md5sums match) - licensing fine - naming fine - lines <= 80 where possible - macros good, clean used appropriately - rpmlint fine: $ rpmlint /home/overholt/rpmbuild/SRPMS/maven-plugin-bundle-2.0.0-1.fc11.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint /home/overholt/rpmbuild/RPMS/noarch/maven-plugin-bundle-2.0.0-1.fc11.noarch.rpm maven-plugin-bundle.noarch: W: no-documentation maven-plugin-bundle.noarch: W: non-conffile-in-etc /etc/maven/fragments/maven-plugin-bundle 1 packages and 0 specfiles checked; 0 errors, 2 warnings. $ rpmlint /home/overholt/rpmbuild/RPMS/noarch/maven-plugin-bundle-javadoc-2.0.0-1.fc11.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. (In reply to comment #1) > X won't build (needs additional BRs -- see > http://overholt.fedorapeople.org/maven-plugin-bundle.spec) Thanks, Fixed. > X probably needs Requires fixed up to match or be similar to BRs Fixed. Maven plugins are needed only at build time. > X the last sentence of the description should be removed. Fixed. > X files good except for %{_javadir} line ... %{_javadir}/*, perhaps? > Fixed. New sources: Spec URL: http://akurtakov.fedorapeople.org/maven-plugin-bundle.spec SRPM URL: http://akurtakov.fedorapeople.org/maven-plugin-bundle-2.0.0-2.fc11.src.rpm Looks good. Approved. New Package CVS Request ======================= Package Name: maven-plugin-bundle Short Description: Maven Bundle Plugin Owners: akurtakov Branches: InitialCC: CVS Done Build in rawhide. |