Bug 521989
Summary: | New Package for Dogtag PKI:pki-util | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Kevin Wright <kwright> |
Component: | Package Review | Assignee: | Dennis Gilmore <dennis> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | low | ||
Version: | rawhide | CC: | alee, awnuk, cfu, fedora-package-review, gsterlin, jmagne, mharmsen, notting |
Target Milestone: | --- | Flags: | dennis:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | 1.3.0-5.el5 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2010-01-07 21:42:06 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 520534, 521996, 522207 |
Description
Kevin Wright
2009-09-09 00:52:08 UTC
first pass at getting pki-util into Fedora. The pki-util.spec file can be downloaded from: http://people.redhat.com/kwright/pki-util/pki-util.spec The source rpm can be downloaded from: http://people.redhat.com/kwright/pki-util/pki-util-1.3.0-1.fc11.src.rpm Removing the NotReady flag from the Whiteboard. Dogtag is an enterprise software system designed to manage enterprise Public Key Infrastructure (PKI) deployments. The Dogtag PKI Utility Framework is required by the following four Dogtag PKI subsystems: the Dogtag Certificate Authority the Dogtag Data Recovery Manager the Dogtag Online Certificate Status Protocol Manager, and the Dogtag Token Key Service updated spec file and src rpm: Spec URL: http://people.redhat.com/kwright/pki-util/pki-util.spec SRPM URL: http://people.redhat.com/kwright/pki-util/pki-util-1.3.0-1.fc11.src.rpm From the changelog: * Mon Nov 2 2009 Matthew Harmsen <mharmsen> 1.3.0-2 - Bugzilla Bug #521989 - packaging for Fedora Dogtag - Take ownership of directories Updated spec file and src rpm: Spec URL: http://people.redhat.com/kwright/pki-util/pki-util.spec SRPM URL: http://people.redhat.com/kwright/pki-util/pki-util-1.3.0-2.fc11.src.rpm from the java guidelines Directory structure All JAR files MUST go into %{_javadir}. Exceptions include JNI-using JAR files , and application-specific JAR files (ie. JAR files that can only reasonably be used as part of an application and therefore constitute application-private data). Java API documentation uses a system known as javadoc. All javadocs MUST be installed into %{_javadocdir}. I feel like the jars should be in %{_javadir} not %{_datadir}/java/pki/ if there is a valid reason that im missing for it to be elsewhere. either way it should be using the correct %{_javadir} macros. From the comment above: "Exceptions include JNI-using JAR files, and application-specific JAR files (ie. JAR files that can only reasonably be used as part of an application and therefore constitute application-private data)." Since all jars and directories under "/usr/share/java/pki/" are specific to the Dogtag application (e. g. - "pki"), are you simply asking us to change "%{_datadir}/java/pki/" to "%{_javadir}/pki/"? im asking why should it be in %{_javadir}/pki/ and not %{_javadir}/ is there some reason the jars should not be easily available for other jars? at the least you should be using %{_javadir}/pki/ but i dont see why it should not be available for all to use. This bug was reviewed during the daily PKI scrum meeting on November 24, 2009, and all on the PKI team agreed that the jar files constitute application-specific data, not general-use libraries. All of these jars constitute a PKI application consisting of four separate servers that sit on top of tomcat5, and although some of these jars have the notion of being "public" versus "private", these "public" API jars are intended to be used for development of plug-ins specific to this PKI application. As such, while it was determined that it makes more sense for the jars to remain in their current directories, the changes from "%{_datadir}/java/pki/" to "%{_javadir}/pki/" will be made to the spec file. * Tue Nov 24 2009 Matthew Harmsen <mharmsen> 1.3.0-3 - Bugzilla Bug #521989 - packaging for Fedora Dogtag - Use "_javadir" macro when appropriate Updated spec file and src rpm: Spec URL: http://people.redhat.com/kwright/pki-util/pki-util.spec SRPM URL: http://people.redhat.com/kwright/pki-util/pki-util-1.3.0-3.fc11.src.rpm Comment #9 applies to this "pki-util" package (as well as other application-specific packages such as "pki-common"). Other "top-level" packages such as "pki-ca" and "pki-java-tools" among others will move their packages to be directly under %{_javadir}. Comment #11 should say: Other "top-level" packages such as "pki-ca" and "pki-java-tools" among others will move their "jars" to be directly under %{_javadir}. It all looks good now. there is a consistent use of macros. rpmlint is silent license is ok spec is clear and legible source matches sha256sum pki-util-1.3.0.tar.gz fedora/SOURCES/pki-util-1.3.0.tar.gz 512c826e870d2bf631f71d1ffeb31333936296a55c9e0892bcf0cafe5ea10319 pki-util-1.3.0.tar.gz 512c826e870d2bf631f71d1ffeb31333936296a55c9e0892bcf0cafe5ea10319 fedora/SOURCES/pki-util-1.3.0.tar.gz approved New Package CVS Request ======================= Package Name: pki-util Short Description: The Dogtag PKI Utility Framework is required by the following four Dogtag PKI subsystems: the Dogtag Certificate Authority, the Dogtag Data Recovery Manager, the Dogtag Online Certificate Status Protocol Manager, and the Dogtag Token Key Service. Owners: kwright Branches: F-11, F-12, EL-5 InitialCC: ausil Changing the short description New Package CVS Request ======================= Package Name: pki-util Short Description: The Dogtag PKI Utility Framework is required by various dogtag packages. Owners: kwright Branches: F-11, F-12, EL-5 InitialCC: ausil Short Description: The Dogtag PKI Utility Framework cvs done. pki-util-1.3.0-4.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/pki-util-1.3.0-4.fc11 pki-util-1.3.0-4.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/pki-util-1.3.0-4.fc12 pki-util-1.3.0-4.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/pki-util-1.3.0-4.el5 pki-util-1.3.0-4.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update pki-util'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-5/FEDORA-EPEL-2009-1044 pki-util-1.3.0-4.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update pki-util'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-13624 pki-util-1.3.0-4.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update pki-util'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2009-13650 pki-util-1.3.0-4.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. pki-util-1.3.0-4.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. pki-util-1.3.0-4.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. pki-util-1.3.0-5.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/pki-util-1.3.0-5.fc11 pki-util-1.3.0-5.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/pki-util-1.3.0-5.fc12 pki-util-1.3.0-5.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/pki-util-1.3.0-5.el5 pki-util-1.3.0-5.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. pki-util-1.3.0-5.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. pki-util-1.3.0-5.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. |