Bug 522111
| Summary: | Radiusd init script does not support force-reload action | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Eduard Benes <ebenes> | ||||
| Component: | freeradius | Assignee: | John Dennis <jdennis> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 12 | CC: | jdennis | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | |||||||
| : | 522118 539466 (view as bug list) | Environment: | |||||
| Last Closed: | 2010-01-07 17:24:12 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 521669, 539466 | ||||||
| Attachments: |
|
||||||
Ohh! Having another look at the init script, this is REALLY a bad practice and should be fixed in /etc/rc.d/init.d/radiusd: [ -f $RADIUSD ] || exit 0 [ -f $CONFIG ] || exit 0 Please make it conform to following guidelines, thanks. [1] - https://fedoraproject.org/wiki/FCNewInit/Initscripts [2] - https://fedoraproject.org/wiki/Packaging/SysVInitScript [3] - http://refspecs.linux-foundation.org/LSB_3.2.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html This bug appears to have been reported against 'rawhide' during the Fedora 12 development cycle. Changing version to '12'. More information and reason for this action is here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping Created attachment 375915 [details]
proposed new initscript
I have reworked the initscript and it is attached. Before committing it I thought I would post it here for review just to make sure all your concerns are addressed.
fixed as of 2.1.7-3 |
Description of problem: Testing init script according to guidelines at [1],[2],[3] shows that radiusd does not recognize 'force-reload' action, as required by LSB. Version-Release number of selected component (if applicable): freeradius RPM version: 2.1.6-6.fc12 Actual results: # service radiusd force-reload ; echo $? Usage: /etc/init.d/radiusd {start|stop|status|restart|reload|condrestart} 1 # service radiusd hello; echo $? Usage: /etc/init.d/radiusd {start|stop|status|restart|reload|condrestart} 1 Also it would be nice to return 3, rather than 1 (unimplemented feature). Expected results: recognize the force-reload action and according to [1] do: * force-reload: "force-reload cause the configuration to be reloaded if the service supports this, otherwise restart the service if it is running." Additional info: [1] - https://fedoraproject.org/wiki/FCNewInit/Initscripts [2] - https://fedoraproject.org/wiki/Packaging/SysVInitScript [3] - http://refspecs.linux-foundation.org/LSB_3.2.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html