Bug 522111 - Radiusd init script does not support force-reload action
Summary: Radiusd init script does not support force-reload action
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: freeradius
Version: 12
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: John Dennis
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: InitScriptsProject 539466
TreeView+ depends on / blocked
 
Reported: 2009-09-09 14:04 UTC by Eduard Benes
Modified: 2010-01-07 17:24 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
: 522118 539466 (view as bug list)
Environment:
Last Closed: 2010-01-07 17:24:12 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
proposed new initscript (2.19 KB, text/plain)
2009-12-03 21:12 UTC, John Dennis
no flags Details

Description Eduard Benes 2009-09-09 14:04:02 UTC
Description of problem:
Testing init script according to guidelines at [1],[2],[3] shows that radiusd
does not recognize 'force-reload' action, as required by LSB.

Version-Release number of selected component (if applicable):
freeradius RPM version: 2.1.6-6.fc12

Actual results:
# service radiusd force-reload ; echo $?
Usage: /etc/init.d/radiusd {start|stop|status|restart|reload|condrestart}
1
# service radiusd hello; echo $?
Usage: /etc/init.d/radiusd {start|stop|status|restart|reload|condrestart}
1
Also it would be nice to return 3, rather than 1 (unimplemented feature).

Expected results:
recognize the force-reload action and according to [1] do:
 * force-reload: "force-reload cause the configuration to be reloaded if the
service supports this, otherwise restart the service if it is running." 

Additional info:
[1] - https://fedoraproject.org/wiki/FCNewInit/Initscripts
[2] - https://fedoraproject.org/wiki/Packaging/SysVInitScript
[3] - http://refspecs.linux-foundation.org/LSB_3.2.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html

Comment 1 Eduard Benes 2009-09-09 14:10:08 UTC
Ohh! Having another look at the init script, this is REALLY a bad practice and should be fixed in /etc/rc.d/init.d/radiusd:

[ -f $RADIUSD ] || exit 0
[ -f $CONFIG ] || exit 0

Please make it conform to following guidelines, thanks.

[1] - https://fedoraproject.org/wiki/FCNewInit/Initscripts
[2] - https://fedoraproject.org/wiki/Packaging/SysVInitScript
[3] -
http://refspecs.linux-foundation.org/LSB_3.2.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html

Comment 2 Bug Zapper 2009-11-16 12:06:30 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 12 development cycle.
Changing version to '12'.

More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 3 John Dennis 2009-12-03 21:12:19 UTC
Created attachment 375915 [details]
proposed new initscript

I have reworked the initscript and it is attached. Before committing it I thought I would post it here for review just to make sure all your concerns are addressed.

Comment 4 John Dennis 2010-01-07 17:24:12 UTC
fixed as of 2.1.7-3


Note You need to log in before you can comment on or make changes to this bug.