Bug 522600
| Summary: | bnx2x: increase coalescing granularity to 4us instead of 12us | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | Flavio Leitner <fleitner> | ||||
| Component: | kernel | Assignee: | Stanislaw Gruszka <sgruszka> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Red Hat Kernel QE team <kernel-qe> | ||||
| Severity: | high | Docs Contact: | |||||
| Priority: | high | ||||||
| Version: | 5.4 | CC: | cward, eilong, peterm, qcai, tao, vanhoof, vladz | ||||
| Target Milestone: | rc | ||||||
| Target Release: | 5.5 | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2010-03-30 07:27:16 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 515716 | ||||||
| Bug Blocks: | 525215, 533192, 533941 | ||||||
| Attachments: |
|
||||||
|
Description
Flavio Leitner
2009-09-10 19:38:41 UTC
Hi Eilon, Vladislav. Could you guys give us a status update on this? thank you! Hi, My apologies for the late response - I was on vacation. I can provide a patch to set the granularity to 4us instead of 12, but internal testing did not show any improvement. This was expected due to FW mechanism that sends the first interrupt as soon as it is received and only then enforces the required minimal time before issuing the second interrupt. So if a packet was received after more than 12us (or 48 as it is configured by default) it will cause an interrupt to be issued immediately - decreasing the minimal timeout to 4us did not actually improve anything. I will post this patch anyway to Dave Miller's net-next once the merge window will open. Regards, Eilon Hi Eilon, Do you mind to attach the patch here too? I think the merge window isn't opened yet and we can be testing it on our test system too. thanks, Flavio Created attachment 364942 [details]
bnx2x: 4us coalescing granularity
This patch will do the trick
Hi Eilon, I thought it would require a firmware change too, right? Can you provide? Or where can we get it? thanks! Actually, this patch is enough. No FW change is required. This change will set the HW timers that the FW is using to 4us instead of 12us so the FW itself does not need to change. Regards, Eilon Hi, This patch is part of version 1.52.1-5 which is integrated to RH5.5 as part of BZ 515716. Regards, Eilon (In reply to comment #12) > This patch is part of version 1.52.1-5 which is integrated to RH5.5 as part of > BZ 515716. Yes. I decide to do not close this bug as duplicate just for additional testing. in kernel-2.6.18-181.el5 You can download this test kernel from http://people.redhat.com/dzickus/el5 Please update the appropriate value in the Verified field (cf_verified) to indicate this fix has been successfully verified. Include a comment with verification details. *** Bug 509585 has been marked as a duplicate of this bug. *** ~~ Attention Customers and Partners - RHEL 5.5 Beta is now available on RHN ~~ RHEL 5.5 Beta has been released! There should be a fix present in this release that addresses your request. Please test and report back results here, by March 3rd 2010 (2010-03-03) or sooner. Upon successful verification of this request, post your results and update the Verified field in Bugzilla with the appropriate value. If you encounter any issues while testing, please describe them and set this bug into NEED_INFO. If you encounter new defects or have additional patch(es) to request for inclusion, please clone this bug per each request and escalate through your support representative. An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHSA-2010-0178.html |