Bug 523599 (perl-Try-Tiny)

Summary:	Review Request: perl-Try-Tiny - Minimal try/catch with proper localization of $@
Product:	[Fedora] Fedora	Reporter:	Chris Weyl <cweyl>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	rawhide	CC:	fedora-package-review, notting, panemade, paul, tremble
Target Milestone:	---	Flags:	panemade: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://search.cpan.org/dist/Try-Tiny
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-09-18 05:51:50 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Chris Weyl 2009-09-16 05:20:31 UTC

Spec URL: http://fedorapeople.org/~cweyl/review/perl-Try-Tiny.spec
SRPM URL: http://fedorapeople.org/~cweyl/review/perl-Try-Tiny-0.02-1.fc11.src.rpm

Description:
The main focus of this module is to provide simple and reliable error
handling for those having a hard time installing TryCatch, but who still
want to write correct 'eval' blocks without 5 lines of boilerplate each
time.

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1681981

Additional Comment:

This is an additional dep of the latest GA Moose.

*rt-0.10

Comment 1 Parag AN(पराग) 2009-09-17 08:42:11 UTC

Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1681981
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
5255d1014e32556aa38ecb4a6382b0cec1e9f439  Try-Tiny-0.02.tar.gz

+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=2, Tests=21,  0 wallclock secs ( 0.02 usr  0.00 sys +  0.05 cusr  0.01 csys =  0.08 CPU)
+ Package perl-Try-Tiny-0.02-1.fc12.noarch =>
Provides: perl(Try::Tiny) = 0.02
Requires: perl(strict) perl(vars) rpmlib(VersionedDependencies) <= 3.0.3-1

+ Not a GUI application

APPROVED.

Comment 2 Chris Weyl 2009-09-17 15:17:31 UTC

New Package CVS Request
=======================
Package Name: perl-Try-Tiny
Short Description: Minimal try/catch with proper localization of $@
Owners: cweyl
Branches: F-10 F-11 devel
InitialCC: perl-sig

Comment 3 Kevin Fenzi 2009-09-17 19:14:06 UTC

cvs done.

Comment 4 Chris Weyl 2009-09-18 05:51:50 UTC

Thanks for the review! :-)

Comment 5 Mark Chappell 2010-07-09 10:09:57 UTC

Package Change Request
======================
Package Name: perl-Try-Tiny
New Branches: EL-6
Owners: tremble    

cweyl has previously expressed that he is happy for others to request EPEL
branches

Comment 6 Kevin Fenzi 2010-07-09 18:14:00 UTC

CVS done (by process-cvs-requests.py).

Comment 7 Mark Chappell 2010-11-02 09:06:30 UTC

Package Change Request
======================
Package Name: perl-Try-Tiny
New Branches: EL-5 EL-4
Owners: tremble pghmcfc

Comment 8 Kevin Fenzi 2010-11-03 03:55:45 UTC

Git done (by process-git-requests).

Comment 9 Paul Howarth 2010-11-03 22:04:08 UTC

EPEL 4 and 5 builds done (version 0.07) and submitted for testing.