Spec URL: http://fedorapeople.org/~cweyl/review/perl-Try-Tiny.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-Try-Tiny-0.02-1.fc11.src.rpm Description: The main focus of this module is to provide simple and reliable error handling for those having a hard time installing TryCatch, but who still want to write correct 'eval' blocks without 5 lines of boilerplate each time. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1681981 Additional Comment: This is an additional dep of the latest GA Moose. *rt-0.10
Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1681981 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 5255d1014e32556aa38ecb4a6382b0cec1e9f439 Try-Tiny-0.02.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=2, Tests=21, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.05 cusr 0.01 csys = 0.08 CPU) + Package perl-Try-Tiny-0.02-1.fc12.noarch => Provides: perl(Try::Tiny) = 0.02 Requires: perl(strict) perl(vars) rpmlib(VersionedDependencies) <= 3.0.3-1 + Not a GUI application APPROVED.
New Package CVS Request ======================= Package Name: perl-Try-Tiny Short Description: Minimal try/catch with proper localization of $@ Owners: cweyl Branches: F-10 F-11 devel InitialCC: perl-sig
cvs done.
Thanks for the review! :-)
Package Change Request ====================== Package Name: perl-Try-Tiny New Branches: EL-6 Owners: tremble cweyl has previously expressed that he is happy for others to request EPEL branches
CVS done (by process-cvs-requests.py).
Package Change Request ====================== Package Name: perl-Try-Tiny New Branches: EL-5 EL-4 Owners: tremble pghmcfc
Git done (by process-git-requests).
EPEL 4 and 5 builds done (version 0.07) and submitted for testing.