Bug 523756
| Summary: | Review Request: iwl1000-firmware - Firmware for Intel® PRO/Wireless 1000 B/G/N network adaptors | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | John W. Linville <linville> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | dongpo.liu, fedora-package-review, jane.lv, jvillalo, luyu, notting |
| Target Milestone: | --- | Flags: | j:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 128.50.3.1-1.fc11 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-10-03 19:00:28 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 483098 | ||
|
Description
John W. Linville
2009-09-16 15:05:46 UTC
I guess packages don't get much simpler than this. It looks functionally equivalent to the existing iwl5000-firmware package; since the licenses are exactly the same I'm going to assume that everything is OK there. This package, like the other firmware packages, have no dependencies. I'm going to assume that's OK as well, and that weird install-time ordering won't somehow cause this package to be installed before udev (or if that nothing suffers if that does manage to happen). I haven't the hardware to test this, but I'm sure if anything doesn't work, it wouldn't be due to the trivial packaging. * source files match upstream. sha256sum: 7e81ddad18acec19364c9df22496e8afae99a2e1490b2b178e420b52d443728d iwlwifi-1000-ucode-128.50.3.1.tgz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is acceptable for firmware. * license text included in package. * latest version is being packaged. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane: iwl1000-firmware = 128.50.3.1-1.fc12 = (none) * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED The package review process needs reviewers! If you haven't done any package reviews recently, please consider doing one. New Package CVS Request ======================= Package Name: iwl1000-firmware Short Description: Firmware for Intel® PRO/Wireless 1000 B/G/N network adaptors Owners: linville Branches: F-11 F-12 InitialCC: linville cvs done. iwl1000-firmware-128.50.3.1-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/iwl1000-firmware-128.50.3.1-1.fc11 iwl1000-firmware-128.50.3.1-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. |