Bug 523756 - Review Request: iwl1000-firmware - Firmware for Intel® PRO/Wireless 1000 B/G/N network adaptors
Summary: Review Request: iwl1000-firmware - Firmware for Intel® PRO/Wireless 1000 B/G...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 483098
TreeView+ depends on / blocked
 
Reported: 2009-09-16 15:05 UTC by John W. Linville
Modified: 2009-10-03 19:00 UTC (History)
6 users (show)

Fixed In Version: 128.50.3.1-1.fc11
Clone Of:
Environment:
Last Closed: 2009-10-03 19:00:28 UTC
Type: ---
Embargoed:
j: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description John W. Linville 2009-09-16 15:05:46 UTC
Spec URL: http://linville.fedorapeople.org/iwl1000-firmware.spec
SRPM URL: http://linville.fedorapeople.org/iwl1000-firmware-128.50.3.1-1.fc11.src.rpm
Description:

This package contains the firmware required by the iwlagn driver
for Linux to support the iwl1000 hardware.  Usage of the firmware
is subject to the terms and conditions contained inside the provided
LICENSE file. Please read it carefully.

Comment 1 Jason Tibbitts 2009-09-23 07:24:19 UTC
I guess packages don't get much simpler than this.  It looks functionally equivalent to the existing iwl5000-firmware package; since the licenses are exactly the same I'm going to assume that everything is OK there.

This package, like the other firmware packages, have no dependencies.  I'm going to assume that's OK as well, and that weird install-time ordering won't somehow cause this package to be installed before udev (or if that nothing suffers if that does manage to happen).

I haven't the hardware to test this, but I'm sure if anything doesn't work, it wouldn't be due to the trivial packaging.

* source files match upstream.  sha256sum:                          
   7e81ddad18acec19364c9df22496e8afae99a2e1490b2b178e420b52d443728d
   iwlwifi-1000-ucode-128.50.3.1.tgz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.                                                              
* description is OK.                                                          
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is acceptable for firmware.
* license text included in package.
* latest version is being packaged.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
   iwl1000-firmware = 128.50.3.1-1.fc12
  =
   (none)

* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

The package review process needs reviewers!  If you haven't done any package
reviews recently, please consider doing one.

Comment 2 John W. Linville 2009-09-29 17:32:21 UTC
New Package CVS Request
=======================
Package Name: iwl1000-firmware
Short Description: Firmware for Intel® PRO/Wireless 1000 B/G/N network adaptors
Owners: linville
Branches: F-11 F-12
InitialCC: linville

Comment 3 Kevin Fenzi 2009-09-29 20:15:51 UTC
cvs done.

Comment 4 Fedora Update System 2009-09-30 15:05:57 UTC
iwl1000-firmware-128.50.3.1-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/iwl1000-firmware-128.50.3.1-1.fc11

Comment 5 Fedora Update System 2009-10-03 19:00:22 UTC
iwl1000-firmware-128.50.3.1-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.