Bug 525358 (python-assets)

Hi, here is my /informal/ review,

**NOK** - rpmlint output
---------------------
[build@f12-alpha SPECS]$ rpmlint python-assets.spec 
python-assets.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 6)
---------------------
Please fix the above.(use consistently either tabs or spaces)

OK - %{?dist} tag is used in release
OK - The package must be named according to the Package Naming Guidelines.
OK - The spec file name must match the base package %{name}
OK - The package must meet the Packaging Guidelines
OK - If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc

OK - The package must be licensed with a Fedora approved license and
meet the Licensing Guidelines (license is GPLv2)

NA - Every binary RPM package which stores shared library files must
call ldconfig in %post and %postun
OK - The package MUST successfully compile and build
koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1702920
OK - The spec file must be written in American English.
OK - The spec file for the package MUST be legible
OK - The sources used to build the package must match the upstream source, as
provided in the spec URL.
sha256sum: eef40e4714f019d76bf9ab44c0fe27e3e6ec5980918012caf81b2e3693c78d09  assets-0.1.0.tar.gz

NA - The spec file MUST handle locales properly (no translations)
NA - The package is not relocatable
OK - A package must own all directories that it creates
OK - A Fedora package must not list a file more than once in the spec file's
%files listings
OK - Permissions on files must be set properly
OK - Each package must have a %clean section
OK - Each package must consistently use macros
OK - The package must contain code, or permissible content 
OK - Large documentation files must go in a -doc subpackage -- No large documentation
OK - If a package includes something as %doc, it must not affect the runtime of
the application
NA - Header files must be in a -devel package -- no devel package
NA - Static libraries must be in a -static package -- no static package
NA - Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
OK - Packages must NOT contain any .la libtool archives
NA - Packages containing GUI applications MUST include a .desktop file 
OK - No file conflicts with other packages and no general names.

OK- At the beginning of %install, each package MUST run rm -rf %{buildroot}
**NOTE**: I think you can avoid the "rm -rf %{buildroot}" in %install section, if you're building _only_ for F11 and above.(IIRC,this guideline is not /yet/ updated in the packaging guidelines )

OK - All file names in rpm packages must be valid UTF-8
OK - The package does not yet exist in Fedora. The Review Request is not a
duplicate.


Please correct me, if I'm wrong somewhere.

Oops, not sure how that got in there.  Fixed and uploaded to fedorapeople.  Also fixed in python-wehjit.spec.

Thanks for catching this!

Jason,

thanks. yes, rpmlint is clean now. 

On a side note, even I'm new to packaging. As you may already be aware of, only a registered sponsor can approve/review "officially" the first package.

Kashyap, your review was very thorough. If you are looking for a sponsor in the future, feel free to let me know.

Jason, in the future, for any change, no matter how small, please increment Release and add a changelog entry to the spec file.

This package is approved and I will sponsor you.

New Package CVS Request
=======================
Package Name: python-assets
Short Description: Cache-friendly asset management via content-hash-naming
Owners: jderose
Branches: F-12
InitialCC:

cvs done.

This is built in rawhide, closing.

New Package CVS Request
=======================
Package Name: python-assets
Short Description: Cache-friendly asset management via content-hash-naming
Owners: jderose
Branches: F-11
InitialCC:

This package is already in the distribution, so I'm not sure what's being
requested here.  Are you just requesting additional branches?  Please file a
change request if that's the case.

I'm requesting a Fedora 11 branch (currently I just have Fedora 12 and rawhide).  Is a change request a new bug, or a modification to this bug?

Thanks!

cvs done. (new f11 branch added)