Bug 525361 (python-wehjit) - Review Request: python-wehjit - A Python web-widget library
Summary: Review Request: python-wehjit - A Python web-widget library
Keywords:
Status: CLOSED RAWHIDE
Alias: python-wehjit
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Tom "spot" Callaway
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: python-assets
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-09-24 03:23 UTC by Jason Gerard DeRose
Modified: 2010-01-31 18:08 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2010-01-21 01:19:43 UTC
Type: ---
Embargoed:
tcallawa: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Jason Gerard DeRose 2009-09-24 03:23:52 UTC
Spec URL: http://jderose.fedorapeople.org/wehjit/0.1.0/python-wehjit.spec
SRPM URL: http://jderose.fedorapeople.org/wehjit/0.1.0/python-wehjit-0.1.0-1.fc11.src.rpm
Description: wehjit is a Python library for for building XHTML widgets for web applications and web pages.  It encapsulates the XHTML (a Genshi XML template), CSS, and JavaScript for each widget into a plugin.

This is my first package and I need a sponsor.

Comment 1 Tom "spot" Callaway 2009-09-24 19:59:07 UTC
Review
=======

(Based on local testing with python-assets)

Good:

- rpmlint checks return nothing
- package meets naming guidelines
- package meets packaging guidelines (python)
- license (GPLv3+) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream (6f95dd7756c8cb0e43cc5ce51af33cd40429536a2fee5e68144e899d3e55412a)
- package compiles on devel (noarch)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

APPROVED.

Comment 2 Jason Gerard DeRose 2009-09-24 22:24:34 UTC
New Package CVS Request
=======================
Package Name: python-wehjit
Short Description: A Python web-widget library
Owners: jderose
Branches: F-12
InitialCC:

Comment 3 Kevin Fenzi 2009-09-25 16:33:32 UTC
cvs done.

Comment 4 Tom "spot" Callaway 2010-01-21 01:19:43 UTC
Built in rawhide, closing out.

Comment 5 Jason Gerard DeRose 2010-01-27 15:44:27 UTC
New Package CVS Request
=======================
Package Name: python-wehjit
Short Description: A Python web-widget library
Owners: jderose
Branches: F-11
InitialCC:

Comment 6 Jason Tibbitts 2010-01-27 21:51:41 UTC
I don't understand what's being requested here.  This package already exists,
so submitting a new package request doesn't make sense.  Are you just asking
for an additional branch?

Comment 7 Kevin Fenzi 2010-01-31 18:08:28 UTC
yes, seems they want a F-11 branch. 

cvs done.


Note You need to log in before you can comment on or make changes to this bug.