Bug 526204

Full review:

1. Please add a fontconfig file (fixed is monospace, that's easy)

2. Please correct the licensing tag, I doubt fixed uses 3 different licenses

3. Please remove 
Requires(pre): fontconfig
BuildRequires: xorg-x11-font-utils

(or tell me where they are used)

4. Please add a %build section (even if empty). rpm does not like specs without %build

5. Please put the URL in URL not in description (and limit your description line lenght to 80c)

6. Please compress the resulting pcf files

7. Why do you ship the Lucida license file ?

8. It would be neat to edit the readme so it does not references fonts not present in the rpm

9. it seems fontconfig reads the family name in the fonts as "MiscFixed". Please rename yout package ucs-miscfixed-fonts

And that should be all

Done all the changes, not much sure about license, please guide me if any problem

SPEC URL : http://pravins.fedorapeople.org/ucs-miscfixed-fonts.spec

SRPM URL : http://pravins.fedorapeople.org/ucs-miscfixed-fonts-0.3-2.fc11.src.rpm

fixed licensing thing as well as per https://bugzilla.redhat.com/show_bug.cgi?id=225617#c19

updated

SPEC URL : http://pravins.fedorapeople.org/ucs-miscfixed-fonts.spec


SRPM URL : http://pravins.fedorapeople.org/ucs-miscfixed-fonts-0.3-3.fc11.src.rpm

1. 55 as fontconfig priority will preempt the default distro monospace font, don't do that.

⇒ Please read
/usr/share/fontconfig/templates/fontconfig-priorities.txt

2. it seems it does need xorg-x11-font-utils as build requires after all
+ make install DESTDIR=/builddir/build/BUILDROOT/ucs-miscfixed-fonts-0.3-3.fc13.x86_64
sed 's/\<Fixed\>/MiscFixed/' < 4x6.bdf > 4x6.bdf.tmp && bdftopcf 4x6.bdf.tmp > 4x6.pcf && rm 4x6.bdf.tmp || ( rm 4x6.bdf.tmp 4x6.pcf && false )
/bin/sh: bdftopcf: command not found

⇒ please check your package builds in mock or as a koji scratch build before submitting

The rest seems ok. Though since xorg seems to maintain and keep updating its own copy of Markus Kuhn's fonts, I suspect its version will be the better one to keep long term

http://lists.freedesktop.org/archives/xorg/2009-October/047606.html

how about 66 as fontconfig priority?

66 should be safe enough

updated package link

http://pravins.fedorapeople.org/ucs-miscfixed-fonts.spec

http://pravins.fedorapeople.org/ucs-miscfixed-fonts-0.3-4.fc11.src.rpm

Please remove the \ in the %description

Nothing else seems obviously wrong to me

ㅌㅌㅌ APPROVED ㅌㅌㅌ

Thank you for cleaning up the packaging of those old files. Should you want to register them in the legacy core font system, you can take a look at  bug #528675 which is similar (but that's no obligation, core fonts need to die)

⇒ REASSIGNING

can i put cvs request here now?
how to register these fonts in legacy core font system?

(In reply to comment #9)
> can i put cvs request here now?

the fedora-review flag was set to yes

> how to register these fonts in legacy core font system?  

take a look at  bug #528675

New Package CVS Request
=======================
Package Name: ucs-fixed-fonts
Short Description: Selected set of bitmap fonts
Owners: pravins
Branches:
InitialCC: fonts-sig

cvs done.

Thanks Kevin for CVS work
i am waiting for bitmap-fonts merge-review bug once that will also over
i will build both these package simultaneously.

oops, looks like i have done cvs request with wrong package name :(
really sorry for that
it should be usc-miscfixed-fonts

New Package CVS Request
=======================
Package Name: ucs-miscfixed-fonts
Short Description: Selected set of bitmap fonts
Owners: pravins
Branches:
InitialCC: fonts-sig  

can we do something now?

should i raise cvs-request flag again?

Yes, please do reset the flag again if you have a cvs request. 
Don't set needinfo on me, as there are (at least in theory) a pool of folks who do these requests.

(In reply to comment #16)
> Don't set needinfo on me, as there are (at least in theory) a pool of folks who
> do these requests.  

sure, no next time 
thanks for setting flag for me

rename done.

built for rawhide :)
thanks nicholas, kevin and toshio for helping in completing new package process