Bug 526303

This package supports openmoko hardware development and helps those developers get a one click platform for their hardware design. Coupled with Fedora's kicad and this package, the openmoko developers can now work with

svn co https://svn.openmoko.org/trunk/gta02-core/
cd gta02-core/
make update
make sch

instead of this time consuming process
http://svn.openmoko.org/trunk/gta02-core/docs/GETTING-STARTED

scratch build : https://koji.fedoraproject.org/scratch/chitlesh/task_1717189/

Simple Test : fped /usr/share/doc/fped-0/footprints/fbga.fpd

Documentation
firefox /usr/share/doc/fped-0/gui.html

I'll review it shortly.

Few notes:

* Since it is a svn snapshot, please add "0." to Relese. E.g. 

Release: 0.1.r5664%{?dist}

* Please, provide exact instructions on how to build Source0. E.g. something like this:

# svn export -r 5664 http://svn.openmoko.org/trunk/eda/fped fped-0
# tar cjf fped-0.tar.bz fped-0
Source0:        %{name}-%{version}.tar.bz2

Other things looks sane.

Updated
Spec URL: http://chitlesh.fedorapeople.org/RPMS/fped.spec
SRPM URL: http://chitlesh.fedorapeople.org/RPMS/fped-0-0.1.r5664.fc11.src.rpm

Oh, another small note - since you're now using %{name}-${version}.tar.bz2 as the Source0, you don't need to add "-n %{name}" to "%setup -q". Please, remove it.

Assuming, that you'll do it, here is my 

REVIEW:

+ rpmlint is silent.
+ The package is named according to the Package Naming Guidelines .
+ The spec file name matches the base package %{name}, in the format %{name}.spec .
+ The package meets the Packaging Guidelines .
+ The package is licensed with a Fedora approved license and meets the Licensing Guidelines .
+ The License field in the package spec file matches the actual license.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package matches the upstream source, as provided in the spec URL. 

[petro@Sulaco BUILD]$ diff -ru fped fped-0/
[petro@Sulaco BUILD]$ 

+ The package successfully compiles and builds into binary rpms on at least one primary architecture.
+ All build dependencies are listed in BuildRequires.
+ The package does NOT bundle copies of system libraries.
+ The package owns all directories that it creates.
+ The package does not list a file more than once in the spec file's %files listings. 
+ Permissions on files are set properly.
+ The package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
+ The package consistently uses macros.
+ The package contains code, or permissible content.
| Everything, the package includes as %doc, does not affect the runtime of the application.
+ The package does not own files or directories already owned by other packages.
+ All filenames in the packages are valid UTF-8.

APPROVED

(assuming, that you'll fix the %build section).

Thanks Peter.

New Package CVS Request
=======================
Package Name: fped
Short Description: A footprint editor used by openmoko developers
Owners: chitlesh
Branches: F-10 F-11 F-12 EL-5

cvs done.

fped-0-0.1.r5664.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/fped-0-0.1.r5664.fc10

fped-0-0.1.r5664.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/fped-0-0.1.r5664.fc11

fped-0-0.1.r5664.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

fped-0-0.1.r5664.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.