Bug 527308
Summary: | Review Request: xmltooling - XML signing and encrytion library | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Steve Traylen <steve.traylen> |
Component: | Package Review | Assignee: | Mattias Ellert <mattias.ellert> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting |
Target Milestone: | --- | Flags: | mattias.ellert:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-10-19 18:27:56 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 527336 |
Description
Steve Traylen
2009-10-05 22:00:03 UTC
There is a erroneous empty: /usr/share/doc/xmltooling-1.2.2 in xmltooling-doc-1.2.2-1 I'll remove at the next iteration. Fedora review xmltooling-1.2.2-1.fc11.src.rpm 2009-10-16 $ rpmlint 3207912553565521572496900/result/xmltooling/*.rpm xmltooling-devel.x86_64: W: no-documentation 5 packages and 0 specfiles checked; 0 errors, 1 warnings. + rpmlint OK + Package name follows guidelines + Specfile named according to the package + Package's license tag (ASL 2.0) is a Fedora approved license + Package's license matches the license of the sources + The license file (LICENSE.txt) is included as %doc + Specfile is written in legible English + Source matches upstream: 2331cbcf257319c40854cefd1783fa96 xmltooling-1.2.2.tar.gz 2331cbcf257319c40854cefd1783fa96 src/xmltooling-1.2.2.tar.gz Comment: The URL used for the Source is not permanent since it contains as one of the elements in its path the element "latest". When the next release is issued by upstream this URL will no longer exist. It might be better to use a specific version instead of "latest" in the Source URL. + Package compiles in mock (Fedora 11) + Build requirements are sane + Main package calls ldconfig in scriptlets + No bundled libraries - Main package installs files in /usr/share/xml without owning it or without requiring a package that owns it. Suggestion: add Requires: xml-common - The doc package own /usr/share/doc/xmltooling-1.2.2 which is already owned by the main package + Permissions are sane and %files have %defattr + Clean clears buildroot + Spec uses macros consistently + Contains code + Documentation is in doc package + %doc is not runtime essential + Headers are in devel + No static libraries + devel requires main with fully qualified version + Package does not own others directories + Install clears buildroot + Filenames valid UTF-8 http://cern.ch/straylen/rpms/xmltooling/xmltooling-1.2.2-2.fc11.src.rpm http://cern.ch/straylen/rpms/xmltooling/xmltooling.spec * Sat Oct 17 2009 Steve Traylen <steve.traylen> 1.2.2-2 - Change Source URL to be permanent rather than contain "latest" - Require xml-common to bring in /usr/share/xml and also fixed up the duplicate /usr/share/doc/xmltooling-1.2.2 I hope. (The source URL is still a little odd in that it contains the version of opensaml for some reason but hopefully it is permanent.. In time if it goes odd and suddenly moves I'll submit a request upstream to keep xmltooling separate to opensaml. Steve Package approved. New Package CVS Request ======================= Package Name: xmltooling Short Description: XML signing and encrytion library Owners: stevetraylen Branches: F-11 F-12 EL-5 EL-4 InitialCC: cvs done. xmltooling-1.2.2-3.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/xmltooling-1.2.2-3.el5 xmltooling-1.2.2-3.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/xmltooling-1.2.2-3.fc11 xmltooling-1.2.2-3.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/xmltooling-1.2.2-3.fc12 In fact an EL-4 will not be built until an xml-security-c is available for EL4 which it currently is not. xmltooling-1.2.2-3.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. xmltooling-1.2.2-3.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. |