Bug 527308 - Review Request: xmltooling - XML signing and encrytion library
Summary: Review Request: xmltooling - XML signing and encrytion library
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mattias Ellert
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 527336
TreeView+ depends on / blocked
 
Reported: 2009-10-05 22:00 UTC by Steve Traylen
Modified: 2009-11-07 00:22 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-10-19 18:27:56 UTC
Type: ---
Embargoed:
mattias.ellert: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Steve Traylen 2009-10-05 22:00:03 UTC
Spec URL: http://cern.ch/straylen/rpms/xmltooling/xmltooling.spec
SRPM URL: http://cern.ch/straylen/rpms/xmltooling/xmltooling-1.2.2-1.fc11.src.rpm
Description: 
The XMLTooling library contains generic XML parsing and processing
classes based on the Xerces-C DOM. It adds more powerful facilities
for declaring element- and type-specific API and implementation
classes to add value around the DOM, as well as signing and encryption
support.

rpmlint:

$ rpmlint SPECS/xmltooling.spec \
          RPMS/noarch/xmltooling-doc-1.2.2-1.fc11.noarch.rpm \
          RPMS/x86_64/xmltooling-* SRPMS/xmltooling-1.2.2-1.el5.src.rpm 
xmltooling-devel.x86_64: W: no-documentation
5 packages and 1 specfiles checked; 0 errors, 1 warnings.

devel has no docs since in the doc sub-package.

Koji fc12 & fc13 successful:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1729449
http://koji.fedoraproject.org/koji/taskinfo?taskID=1729452

(for information an .el5 build is pending on log4cpp leaving testing)

Comment 1 Steve Traylen 2009-10-05 22:04:17 UTC
There is a erroneous empty:
/usr/share/doc/xmltooling-1.2.2
in
xmltooling-doc-1.2.2-1
I'll remove at the next iteration.

Comment 2 Mattias Ellert 2009-10-16 12:34:16 UTC
Fedora review xmltooling-1.2.2-1.fc11.src.rpm 2009-10-16

$ rpmlint 3207912553565521572496900/result/xmltooling/*.rpm
xmltooling-devel.x86_64: W: no-documentation
5 packages and 0 specfiles checked; 0 errors, 1 warnings.

+ rpmlint OK
+ Package name follows guidelines
+ Specfile named according to the package
+ Package's license tag (ASL 2.0) is a Fedora approved license
+ Package's license matches the license of the sources
+ The license file (LICENSE.txt) is included as %doc
+ Specfile is written in legible English
+ Source matches upstream:

2331cbcf257319c40854cefd1783fa96  xmltooling-1.2.2.tar.gz
2331cbcf257319c40854cefd1783fa96  src/xmltooling-1.2.2.tar.gz

Comment: The URL used for the Source is not permanent since it contains as one
of the elements in its path the element "latest". When the next release is
issued by upstream this URL will no longer exist. It might be better to use
a specific version instead of "latest" in the Source URL.

+ Package compiles in mock (Fedora 11)
+ Build requirements are sane
+ Main package calls ldconfig in scriptlets
+ No bundled libraries

- Main package installs files in /usr/share/xml without owning it or without
  requiring a package that owns it. Suggestion: add Requires: xml-common

- The doc package own /usr/share/doc/xmltooling-1.2.2 which is already owned
  by the main package

+ Permissions are sane and %files have %defattr
+ Clean clears buildroot
+ Spec uses macros consistently
+ Contains code
+ Documentation is in doc package
+ %doc is not runtime essential
+ Headers are in devel
+ No static libraries
+ devel requires main with fully qualified version
+ Package does not own others directories
+ Install clears buildroot
+ Filenames valid UTF-8

Comment 3 Steve Traylen 2009-10-16 22:43:34 UTC
http://cern.ch/straylen/rpms/xmltooling/xmltooling-1.2.2-2.fc11.src.rpm
http://cern.ch/straylen/rpms/xmltooling/xmltooling.spec

* Sat Oct 17 2009 Steve Traylen <steve.traylen> 1.2.2-2
- Change Source URL to be permanent rather than contain "latest"
- Require xml-common to bring in /usr/share/xml


and also fixed up the duplicate /usr/share/doc/xmltooling-1.2.2  I hope.


(The source URL is still a little odd in that it contains the version
 of opensaml for some reason but hopefully it is permanent.. In time
 if it goes odd and suddenly moves I'll submit a request upstream
 to keep xmltooling separate to opensaml.

Steve

Comment 4 Mattias Ellert 2009-10-19 11:08:12 UTC
Package approved.

Comment 5 Steve Traylen 2009-10-19 11:14:43 UTC
New Package CVS Request
=======================
Package Name: xmltooling
Short Description:  XML signing and encrytion library
Owners: stevetraylen
Branches: F-11 F-12 EL-5 EL-4
InitialCC:

Comment 6 Kevin Fenzi 2009-10-19 16:15:36 UTC
cvs done.

Comment 7 Fedora Update System 2009-10-19 18:25:15 UTC
xmltooling-1.2.2-3.el5 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/xmltooling-1.2.2-3.el5

Comment 8 Fedora Update System 2009-10-19 18:25:43 UTC
xmltooling-1.2.2-3.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/xmltooling-1.2.2-3.fc11

Comment 9 Fedora Update System 2009-10-19 18:26:10 UTC
xmltooling-1.2.2-3.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/xmltooling-1.2.2-3.fc12

Comment 10 Steve Traylen 2009-10-19 18:27:56 UTC
In fact an EL-4 will not be built until an xml-security-c 
is available for EL4 which it currently is not.

Comment 11 Fedora Update System 2009-11-06 05:57:03 UTC
xmltooling-1.2.2-3.el5 has been pushed to the Fedora EPEL 5 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2009-11-07 00:22:11 UTC
xmltooling-1.2.2-3.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.