Bug 528469
| Summary: | Review Request: php-ezc-EventLogDatabaseTiein - eZ Components EventLogDatabaseTiein | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Guillaume Kulakowski <guillaume> |
| Component: | Package Review | Assignee: | Remi Collet <fedora> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | 11 | CC: | fedora, fedora-package-review, notting |
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | noarch | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-02-07 10:57:16 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Guillaume Kulakowski
2009-10-12 12:15:33 UTC
SPEC updated : http://llaumgui.fedorapeople.org/review/ez_components/php-ezc-EventLogDatabaseTiein.spec REVIEW: + rpmlint is ok php-ezc-EventLogDatabaseTiein.src: I: checking php-ezc-EventLogDatabaseTiein.noarch: I: checking 2 packages and 1 specfiles checked; 0 errors, 0 warnings. + package name ok + spec file name ok + package meet the PHP Guidelines (new update) + License ok : BSD + License is upstream + spec in english and legible + license file in sources is provided + sources match the upstream sources d261edd630fe9741cfc6be0cf3c41f93 EventLogDatabaseTiein-1.0.2.tgz + Source URL ok + build on F12.x86_64 + BuildRequires (php-pear >= 1:1.4.9-1.2, php-channel(components.ez.no)) ok + no locale + no .so + own all directories that it creates + no duplicate file + %defattr ok + %clean section + use macros consistently + contain code + small documentation not required to run + no devel + no pkgconfig + no sub-package + no GUI + don't own files or directories already owned by other packages + %install start with rm -rf + valid UTF-8 + build in koji http://koji.fedoraproject.org/koji/taskinfo?taskID=1835253 + no test suite + scriptlets ok + Final Requires ok /usr/bin/pear php-common >= 5.2.1 php-pear(components.ez.no/Database) >= 1.2 php-pear(components.ez.no/EventLog) >= 1.0.3 + Final Provides ok php-pear(components.ez.no/EventLogDatabaseTiein) = 1.0.2 php-ezc-EventLogDatabaseTiein = 1.0.2-1.fc8 I think you should keep the Requires php-pear(components.ez.no/Base) >= 1.2. If this package is already required, version could be useful for documentation. **** APPROVED **** New Package CVS Request ======================= Package Name: php-ezc-EventLogDatabaseTiein Short Description: Contains the database writer backend for the EventLog component Owners: llaumgui Branches: F-11 F-12 InitialCC: cvs done. Package Change Request ====================== Package Name: php-ezc-EventLogDatabaseTiein New Branches: EL-6 Owners: llaumgui Git done (by process-git-requests). Package Change Request ====================== Package Name: php-ezc-EventLogDatabaseTiein New Branches: EL-7 Owners: llaumgui Git done (by process-git-requests). |