Bug 528469 - Review Request: php-ezc-EventLogDatabaseTiein - eZ Components EventLogDatabaseTiein
Summary: Review Request: php-ezc-EventLogDatabaseTiein - eZ Components EventLogDatabas...
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: 11
Hardware: noarch
OS: Linux
low
medium
Target Milestone: ---
Assignee: Remi Collet
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-10-12 12:15 UTC by Guillaume Kulakowski
Modified: 2014-09-04 16:55 UTC (History)
3 users (show)

(edit)
Clone Of:
(edit)
Last Closed: 2010-02-07 10:57:16 UTC
fedora: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Guillaume Kulakowski 2009-10-12 12:15:33 UTC
EventLogDatabaseTiein is a part of eZ Components :
https://admin.fedoraproject.org/pkgdb/packages/name/php-channel-ezc

---
Contains the database writer backend for the EventLog component
---

SPEC:
http://llaumgui.fedorapeople.org/review/ez_components/php-ezc-EventLogDatabaseTiein.spec

SRPM:
http://llaumgui.fedorapeople.org/review/ez_components/php-ezc-EventLogDatabaseTiein-1.0.2-1.fc11.src.rpm

RPM:
http://llaumgui.fedorapeople.org/review/ez_components/php-ezc-EventLogDatabaseTiein-1.0.2-1.fc11.noarch.rpm



rpmlint:
builder@enterprise ~> rpmlint rpmbuild/**/php-ezc-EventLogDatabaseTiein   
2 packages and 1 specfiles checked; 0 errors, 0 warnings.



Pear CompatInfo:
+-----------------------------+---------+---+------------+--------------------+
| Files                       | Version | C | Extensions | Constants/Tokens   |
+-----------------------------+---------+---+------------+--------------------+
| ./*                         | 5.1.0   | 0 | date       | __FILE__           |
|                             |         |   | ereg       | catch              |
|                             |         |   |            | implements         |
|                             |         |   |            | private            |
|                             |         |   |            | public             |
|                             |         |   |            | throw              |
|                             |         |   |            | try                |
+-----------------------------+---------+---+------------+--------------------+

Comment 2 Remi Collet 2009-11-28 14:32:15 UTC
REVIEW:

+ rpmlint is ok
php-ezc-EventLogDatabaseTiein.src: I: checking
php-ezc-EventLogDatabaseTiein.noarch: I: checking
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
+ package name ok
+ spec file name ok
+ package meet the PHP Guidelines (new update)
+ License ok : BSD
+ License is upstream 
+ spec in english and legible
+ license file in sources is provided
+ sources match the upstream sources
d261edd630fe9741cfc6be0cf3c41f93  EventLogDatabaseTiein-1.0.2.tgz
+ Source URL ok
+ build  on F12.x86_64
+ BuildRequires (php-pear >= 1:1.4.9-1.2, php-channel(components.ez.no)) ok
+ no locale
+ no .so
+ own all directories that it creates
+ no duplicate file
+ %defattr ok
+ %clean section
+ use macros consistently
+ contain code
+ small documentation not required to run
+ no devel
+ no pkgconfig
+ no sub-package
+ no GUI
+ don't own files or directories already owned by other packages
+ %install start with rm -rf 
+ valid UTF-8
+ build in koji
http://koji.fedoraproject.org/koji/taskinfo?taskID=1835253
+ no test suite
+ scriptlets ok
+ Final Requires ok
/usr/bin/pear  
php-common >= 5.2.1
php-pear(components.ez.no/Database) >= 1.2
php-pear(components.ez.no/EventLog) >= 1.0.3
+ Final Provides ok
php-pear(components.ez.no/EventLogDatabaseTiein) = 1.0.2
php-ezc-EventLogDatabaseTiein = 1.0.2-1.fc8


I think you should keep the Requires php-pear(components.ez.no/Base) >= 1.2. 
If this package is already required, version could be useful for documentation.


**** APPROVED ****

Comment 3 Guillaume Kulakowski 2009-11-30 13:17:19 UTC
New Package CVS Request
=======================
Package Name: php-ezc-EventLogDatabaseTiein
Short Description: Contains the database writer backend for the EventLog component
Owners: llaumgui
Branches: F-11 F-12
InitialCC:

Comment 4 Kevin Fenzi 2009-12-03 06:29:03 UTC
cvs done.

Comment 5 Guillaume Kulakowski 2010-08-29 09:06:58 UTC
Package Change Request
======================
Package Name: php-ezc-EventLogDatabaseTiein
New Branches: EL-6
Owners: llaumgui

Comment 6 Kevin Fenzi 2010-08-29 18:54:24 UTC
Git done (by process-git-requests).

Comment 7 Guillaume Kulakowski 2014-09-02 13:03:48 UTC
Package Change Request
======================
Package Name: php-ezc-EventLogDatabaseTiein
New Branches: EL-7
Owners: llaumgui

Comment 8 Gwyn Ciesla 2014-09-04 16:55:16 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.