Bug 528904

Summary: Review Request: hyphen-grc - Ancient Greek hyphenation patterns
Product: [Fedora] Fedora Reporter: Caolan McNamara <caolanm>
Component: Package ReviewAssignee: Parag AN(पराग) <panemade>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting, panemade
Target Milestone: ---Keywords: Reopened
Target Release: ---Flags: panemade: fedora-review+
kevin: fedora-cvs+
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-10-15 21:55:46 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Caolan McNamara 2009-10-14 09:49:28 UTC
Spec URL: http://people.redhat.com/caolanm/rpms/hyphen-grc.spec
SRPM URL: http://people.redhat.com/caolanm/rpms/hyphen-grc-0.20080616-1.fc11.noarch.rpm
Description: Ancient Greek hyphenation patterns

(OpenOffice.org 3.2 in F-13 will make Ancient Greek an available language)

Comment 1 Parag AN(पराग) 2009-10-14 10:44:38 UTC

*** This bug has been marked as a duplicate of bug 528893 ***

Comment 2 Parag AN(पराग) 2009-10-14 10:47:38 UTC
I am sorry I got confused.

Comment 3 Parag AN(पराग) 2009-10-14 10:48:55 UTC
Actually I see noarch posted so I confused. Can you please post SRPM for hyphen-grc?

Comment 4 Caolan McNamara 2009-10-14 11:51:37 UTC
Silly me.
SRPM URL: http://people.redhat.com/caolanm/rpms/hyphen-grc-0.20080616-1.fc11.src.rpm

Comment 5 Parag AN(पराग) 2009-10-15 08:56:06 UTC
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1746882
+ rpmlint output for SRPM and for RPM is silent.
+ source files match upstream url (sha1sum)
5d162f60cd756c9ff19bd7cd152c45202c6bc8b8  hyph-grc.tex
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI application

APPROVED.

Comment 6 Caolan McNamara 2009-10-15 09:08:40 UTC
New Package CVS Request
=======================
Package Name: hyphen-grc
Short Description: Ancient Greek hyphenation patterns
Owners: caolanm
Branches: devel
InitialCC:

Comment 7 Kevin Fenzi 2009-10-15 17:26:33 UTC
cvs done.