Bug 528893 - Review Request: hunspell-grc - Ancient Greek hunspell dictionaries
Summary: Review Request: hunspell-grc - Ancient Greek hunspell dictionaries
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-10-14 09:00 UTC by Caolan McNamara
Modified: 2009-10-15 22:03 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-10-15 22:03:53 UTC
Type: ---
panemade: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Caolan McNamara 2009-10-14 09:00:02 UTC
Spec URL: http://people.redhat.com/caolanm/rpms/hunspell-grc.spec
SRPM URL: http://people.redhat.com/caolanm/rpms/hunspell-grc-2.1.4-0.1.alpha.fc11.src.rpm
Description: Ancient Greek hunspell dictionaries

(Ancient Greek is an available language in OpenOffice.org 3.2 for F-13)

Comment 1 Parag AN(पराग) 2009-10-14 10:44:38 UTC
*** Bug 528904 has been marked as a duplicate of this bug. ***

Comment 2 Parag AN(पराग) 2009-10-14 11:13:00 UTC
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1745791
+ rpmlint output for SRPM and for RPM is silent.
+ source files match upstream url (sha1sum)
9c794817d75024531f933732d8db14a958c8ea56  grc.oxt
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI application

APPROVED.

Comment 3 Caolan McNamara 2009-10-14 11:46:24 UTC
New Package CVS Request
=======================
Package Name: hunspell-grc
Short Description: Ancient Greek hunspell dictionaries
Owners: caolanm
Branches: devel
InitialCC:

Comment 4 Kevin Fenzi 2009-10-15 17:25:54 UTC
cvs done.


Note You need to log in before you can comment on or make changes to this bug.