Bug 529105

Summary:	Review Request: netperf - Network benchmarking tools
Product:	[Fedora] Fedora	Reporter:	Patrick C. F. Ernzer <pcfe>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED INSUFFICIENT_DATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting, pahan
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-10-15 15:09:21 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Patrick C. F. Ernzer 2009-10-14 23:13:56 UTC

Spec URL: http://pcfe.fedorapeople.org/netperf.spec
SRPM URL: http://pcfe.fedorapeople.org/netperf-4.0.0-0.rc2.1.fc11.src.rpm
Description: netperf4 being GPL2+ (as opposed to netperf2) and needing this for testing, I decided that I might as well package it up.

But, I definitely would like some more eyeballs on the spec, especially

W: configure-without-libdir-spec
  is that acceptable with this package?

W: shared-lib-calls-exit ...
  are these acceptable considering the libraries are only used by netperf?

2 zero length documentation files
  should I exclude them from %doc (as I did with NEWS) or leave them in? Especially examples/TBD seems to be there explicitly to show more examples should be coming from upstream

Is the breakup between netperf and netperf-devel OK?

Plus anything else I may have missed.

Comment 1 Patrick C. F. Ernzer 2009-10-15 15:09:21 UTC

was just made aware of iperf as that's in the repos pounding netperf4 into shape is probably a waste of time.

closing this review request for now, will re-open if it turns out iperf is lacking features that netperf4 provides in a working form

Comment 3 Patrick C. F. Ernzer 2009-10-16 17:05:57 UTC

new files uploaded:

Spec URL: http://pcfe.fedorapeople.org/netperf.spec
SRPM URL: http://pcfe.fedorapeople.org/netperf-4.0.0-0.rc2.3.el5.src.rpm

but man and info pages have 0 length, so not really ready for inclusion