Bug 529283

Summary:	Review Request: fontbox - Java library for working with PDF fonts
Product:	[Fedora] Fedora	Reporter:	Orion Poplawski <orion>
Component:	Package Review	Assignee:	Orcan Ogetbil <oget.fedora>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting, oget.fedora
Target Milestone:	---	Flags:	oget.fedora: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-11-11 04:20:53 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	529441

Description Orion Poplawski 2009-10-15 22:23:37 UTC

Spec URL: http://www.cora.nwra.com/~orion/fedora/fontbox.spec
SRPM URL: http://www.cora.nwra.com/~orion/fedora/fontbox-0.8.0-1.fc12.src.rpm
Description: 
Apache FontBox is an open source Java library for working with PDF fonts.

Koji build (devel/F13):
http://koji.fedoraproject.org/koji/taskinfo?taskID=1748356

Comment 1 Orcan Ogetbil 2009-11-07 20:43:34 UTC

I reviewed this. There are very minor issues that can be fixed before you import:

* rpmlint says:
   W: non-standard-group Development Documentation
      This should be just "Documentation"
   W: libdir-macro-in-noarch-package (main package) %attr(-,root,root) %{_libdir}/gcj/%{name}
      rpmlint is wrong. This one can be ignored.

- Patches should be explained and be submitted to upstream. Since this is a pure Fedora specific patch we can ignore the upstream part.

! %if %{with_gcj}
  %attr(-,root,root) %{_libdir}/gcj/%{name}
  %endif

Here %attr(-,root,root) is not needed. I know this is in the guidelines but they have to be corrected. (I proposed this a while ago but things are going a little slow with updating these guidelines.)


------------------------------------------
This package (fontbox) is APPROVED by oget
------------------------------------------

Comment 2 Orion Poplawski 2009-11-10 03:40:24 UTC

Thanks for the review.  Changes have been made to the spec.

New Package CVS Request
=======================
Package Name: fontbox
Short Description: Java library for working with PDF fonts
Owners: orion
Branches: F-12 F-11 F-10 EL-5
InitialCC:

Comment 3 Kevin Fenzi 2009-11-11 03:43:40 UTC

cvs done.

Comment 4 Orion Poplawski 2009-11-11 04:20:53 UTC

Checked in and built.  Thanks all.