Spec URL: http://www.cora.nwra.com/~orion/fedora/fontbox.spec SRPM URL: http://www.cora.nwra.com/~orion/fedora/fontbox-0.8.0-1.fc12.src.rpm Description: Apache FontBox is an open source Java library for working with PDF fonts. Koji build (devel/F13): http://koji.fedoraproject.org/koji/taskinfo?taskID=1748356
I reviewed this. There are very minor issues that can be fixed before you import: * rpmlint says: W: non-standard-group Development Documentation This should be just "Documentation" W: libdir-macro-in-noarch-package (main package) %attr(-,root,root) %{_libdir}/gcj/%{name} rpmlint is wrong. This one can be ignored. - Patches should be explained and be submitted to upstream. Since this is a pure Fedora specific patch we can ignore the upstream part. ! %if %{with_gcj} %attr(-,root,root) %{_libdir}/gcj/%{name} %endif Here %attr(-,root,root) is not needed. I know this is in the guidelines but they have to be corrected. (I proposed this a while ago but things are going a little slow with updating these guidelines.) ------------------------------------------ This package (fontbox) is APPROVED by oget ------------------------------------------
Thanks for the review. Changes have been made to the spec. New Package CVS Request ======================= Package Name: fontbox Short Description: Java library for working with PDF fonts Owners: orion Branches: F-12 F-11 F-10 EL-5 InitialCC:
cvs done.
Checked in and built. Thanks all.