Bug 530233
| Summary: | Review Request: evtest - Event device test program | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Peter Hutterer <peter.hutterer> |
| Component: | Package Review | Assignee: | Yanko Kaneti <yaneti> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, yaneti |
| Target Milestone: | --- | Flags: | yaneti:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-10-26 23:37:44 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Peter Hutterer
2009-10-21 23:01:29 UTC
I should have added some more info: evtest is the main debugging program for issues with input devices in X to determine whether it's the device's, the kernel's or X's fault. ATM, we're asking users to download and compile the evtest.c file directly, having evtest in the repos seems a tad more userfriendly. Source matches. Builds in mock. Works. rpmlint: evtest.src: W: invalid-license GPL evtest.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 1) The license tag should be changed to GPLv2+ APPROVED Please fix the license before importing. And more appropriate fdo url seems to be http://cgit.freedesktop.org/~whot/evtest/ (In reply to comment #2) > rpmlint: > evtest.src: W: invalid-license GPL > evtest.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 1) > > The license tag should be changed to GPLv2+ > > APPROVED > Please fix the license before importing. (In reply to comment #3) > And more appropriate fdo url seems to be > http://cgit.freedesktop.org/~whot/evtest/ thanks for the review. all three fixed, spec file and new srpm at URLs above if you want to look at it again. New Package CVS Request ======================= Package Name: evtest Short Description: Event device test program Owners: whot Branches: F-11 F-12 License: GPLv2 That is not what evtest.c says, quote: * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. This is GPLv2+ Thanks again. Fixed, same URLs. I think this should be it now, sorry about this mishap. cvs done. Imported and built. Thanks. |