Bug 530233 - Review Request: evtest - Event device test program
Summary: Review Request: evtest - Event device test program
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Yanko Kaneti
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-10-21 23:01 UTC by Peter Hutterer
Modified: 2009-10-26 23:37 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-10-26 23:37:44 UTC
Type: ---
Embargoed:
yaneti: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Peter Hutterer 2009-10-21 23:01:29 UTC
Spec URL: http://people.freedesktop.org/~whot/evtest.spec
SRPM URL: http://people.freedesktop.org/~whot/evtest-1.23-1.fc12.src.rpm
Description: evtest is a simple utility to query information about input devices 
and watch the event stream generated by input devices.

Comment 1 Peter Hutterer 2009-10-21 23:03:39 UTC
I should have added some more info: evtest is the main debugging program for issues with input devices in X to determine whether it's the device's, the kernel's or X's fault. ATM, we're asking users to download and compile the evtest.c file directly, having evtest in the repos seems a tad more userfriendly.

Comment 2 Yanko Kaneti 2009-10-22 05:18:26 UTC
Source matches. Builds in mock. Works.

rpmlint:
evtest.src: W: invalid-license GPL
evtest.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 1)

The license tag should be changed to GPLv2+

APPROVED
Please fix the license before importing.

Comment 3 Yanko Kaneti 2009-10-22 05:34:34 UTC
And more appropriate  fdo url seems to be 
http://cgit.freedesktop.org/~whot/evtest/

Comment 4 Peter Hutterer 2009-10-22 07:09:34 UTC
(In reply to comment #2)
> rpmlint:
> evtest.src: W: invalid-license GPL
> evtest.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 1)
> 
> The license tag should be changed to GPLv2+
> 
> APPROVED
> Please fix the license before importing.  

(In reply to comment #3)
> And more appropriate  fdo url seems to be 
> http://cgit.freedesktop.org/~whot/evtest/  

thanks for the review. all three fixed, spec file and new srpm at URLs above if you want to look at it again.

Comment 5 Peter Hutterer 2009-10-22 07:11:55 UTC
New Package CVS Request
=======================
Package Name: evtest
Short Description: Event device test program 
Owners: whot
Branches: F-11 F-12

Comment 6 Yanko Kaneti 2009-10-22 07:31:33 UTC
License: GPLv2

That is not what evtest.c says, quote:

 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or 
 * (at your option) any later version.

This is GPLv2+

Comment 7 Peter Hutterer 2009-10-22 22:46:00 UTC
Thanks again. Fixed, same URLs. I think this should be it now, sorry about this mishap.

Comment 8 Kevin Fenzi 2009-10-26 20:15:59 UTC
cvs done.

Comment 9 Peter Hutterer 2009-10-26 23:37:44 UTC
Imported and built. Thanks.


Note You need to log in before you can comment on or make changes to this bug.