Bug 530806
| Summary: | Review Request: Pyrit - A GPGPU-driven WPA-PSK key cracker | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lukas Lueg <knabberknusperhaus> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, lemenkov, lmacken, mail, notting, opensource, tomspur |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-11-03 17:19:27 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 201449 | ||
|
Description
Lukas Lueg
2009-10-25 11:16:38 UTC
*** Bug 491428 has been marked as a duplicate of this bug. *** Just a few comments, because I'm no sponsor anyway:
- Some tests are currently failing ( to long to copy&paste here )
- Missing Requires: scapy ( one test fails because of this... )
- The license (as you noted in setup.py) should be GPLv3+
- tests should be part of doc and not installed in /usr/share, except you need
them on runtime.
Please delete all install* lines from %install and include the tests in the
%files section as:
%doc test/*
This will copy all files from test to /usr/share/doc/%{name}-%{version}/
- You don't own %{_datadir}/%{name}/ just the subfiles.
If this package will be deleted on any system out there, the folder
%{_datadir}/%{name}/ will stay there...
When you install the tests with %doc, this won't be needed anymore.
please remove the NotReady from the Whiteboard once you have addressed the issues from comment:2 No response to commentary in nearly two months. I'll close this soon if there's no further response. I'm the upstream maintainer. Comments in 2 where implemented. I'll post in this bug when 0.2.5-final becomes available. The new upstream version 0.3.0-final has been released and I've updated the SPEC: http://www.how-to-properly.com/fedora/pyrit.spec http://www.how-to-properly.com/fedora/pyrit-0.3.0-1.fc12.src.rpm While I'm willing to make further changes in upstream if necessary, version 0.3.0 is ready to be included in Fedora's repository. bump, please comment (In reply to comment #6) > The new upstream version 0.3.0-final has been released and I've updated the > SPEC: > > http://www.how-to-properly.com/fedora/pyrit.spec > http://www.how-to-properly.com/fedora/pyrit-0.3.0-1.fc12.src.rpm The hostname does not resolve here: $ host www.how-to-properly.com Host www.how-to-properly.com not found: 3(NXDOMAIN) Also, did you perform some unofficial reviews? Also, do enter your real name in bugzilla, please. Spec and srpm have not been downloadable for months, and the submitter has not responded to pings or comments. Closing. *** This bug has been marked as a duplicate of bug 691894 *** |