Bug 530806

Summary: Review Request: Pyrit - A GPGPU-driven WPA-PSK key cracker
Product: [Fedora] Fedora Reporter: Lukas Lueg <knabberknusperhaus>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED DUPLICATE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: fedora-package-review, lemenkov, lmacken, mail, notting, opensource, tomspur
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-11-03 13:19:27 EDT Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Bug Depends On:    
Bug Blocks: 201449    

Description Lukas Lueg 2009-10-25 07:16:38 EDT
Spec URL: http://www.how-to-properly.com/fedora/pyrit.spec
SRPM URL: http://www.how-to-properly.com/fedora/pyrit-0.2.5-1.fc11.src.rpm
Description: Pyrit creates massive databases, pre-computing part of the WPA/WPA2-PSK authentication phase in a space-time tradeoff. It exploits the computational power of multiple cores and GPGPU-platforms through ATI-Stream, Nvidia CUDA, OpenCL and VIA Padlock. It is a powerful attack against one of the world's most used security-protocols


I'm the author of Pyrit and this is the follow-up to bug 491428. This is my first fedora-package and I require a sponsor.

PLEASE NOTE that this is a non-final version of upcoming Pyrit 0.2.5 that I'd like to submit for review ONLY. I've already made several changes to upstream in order to fix errors and warnings by rpmlint;
Comment 1 Thomas Spura 2009-11-27 08:35:53 EST
*** Bug 491428 has been marked as a duplicate of this bug. ***
Comment 2 Thomas Spura 2009-11-27 08:49:28 EST
Just a few comments, because I'm no sponsor anyway:

- Some tests are currently failing ( to long to copy&paste here )

- Missing Requires: scapy ( one test fails because of this... )

- The license (as you noted in setup.py) should be GPLv3+

- tests should be part of doc and not installed in /usr/share, except you need 
  them on runtime.
  Please delete all install* lines from %install and include the tests in the
  %files section as:

  %doc test/*

  This will copy all files from test to /usr/share/doc/%{name}-%{version}/

- You don't own %{_datadir}/%{name}/ just the subfiles.
  If this package will be deleted on any system out there, the folder 
  %{_datadir}/%{name}/ will stay there...
  When you install the tests with %doc, this won't be needed anymore.
Comment 3 Till Maas 2009-12-30 14:42:56 EST
please remove the NotReady from the Whiteboard once you have addressed the issues from comment:2
Comment 4 Jason Tibbitts 2010-01-22 17:20:35 EST
No response to commentary in nearly two months.  I'll close this soon if there's no further response.
Comment 5 Lukas Lueg 2010-01-24 06:25:18 EST
I'm the upstream maintainer. Comments in 2 where implemented. I'll post in this bug when 0.2.5-final becomes available.
Comment 6 Lukas Lueg 2010-02-22 04:50:39 EST
The new upstream version 0.3.0-final has been released and I've updated the SPEC:

http://www.how-to-properly.com/fedora/pyrit.spec
http://www.how-to-properly.com/fedora/pyrit-0.3.0-1.fc12.src.rpm


While I'm willing to make further changes in upstream if necessary, version 0.3.0 is ready to be included in Fedora's repository.
Comment 7 Lukas Lueg 2010-04-06 09:47:09 EDT
bump, please comment
Comment 8 Till Maas 2010-06-30 10:23:17 EDT
(In reply to comment #6)
> The new upstream version 0.3.0-final has been released and I've updated the
> SPEC:
> 
> http://www.how-to-properly.com/fedora/pyrit.spec
> http://www.how-to-properly.com/fedora/pyrit-0.3.0-1.fc12.src.rpm

The hostname does not resolve here:

$ host www.how-to-properly.com
Host www.how-to-properly.com not found: 3(NXDOMAIN)
Comment 9 Till Maas 2010-06-30 10:23:46 EDT
Also, did you perform some unofficial reviews?
Comment 10 Michael Schwendt 2010-07-29 10:26:56 EDT
Also, do enter your real name in bugzilla, please.
Comment 11 Jason Tibbitts 2010-11-03 13:19:27 EDT
Spec and srpm have not been downloadable for months, and the submitter has not responded to pings or comments.  Closing.
Comment 12 Fabian Affolter 2011-04-04 11:26:56 EDT

*** This bug has been marked as a duplicate of bug 691894 ***