Bug 533197

Summary:	kvm kmod package should filter only some specific ksym dependencies
Product:	Red Hat Enterprise Linux 5	Reporter:	Eduardo Habkost <ehabkost>
Component:	kvm	Assignee:	Eduardo Habkost <ehabkost>
Status:	CLOSED ERRATA	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	5.4	CC:	dzickus, emcnabb, ovirt-maint, tburke, ykaul
Target Milestone:	rc	Keywords:	ZStream
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	kvm-83-135.el5	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	466961
Clones:	533453 (view as bug list)		Environment:
Last Closed:	2010-03-30 07:54:43 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	466961, 533401
Bug Blocks:	533453, 547293

Description Eduardo Habkost 2009-11-05 15:24:24 UTC

We need to remove this from the kvm spec file:

#FIXME: hack to ignore the ksym() requires because we don't have the
# symbols on the whitelist yet (bz#466961)
%define _use_internal_dependency_generator 0
%define __find_requires sh -c '/usr/lib/rpm/redhat/find-requires "$@" |
%grep -v "ksym("'


This can be done now that the required symbols were added to the whitelist (see bug #466961).

Comment 1 Eduardo Habkost 2009-11-06 15:59:01 UTC

Actually, the ksym dependencies should never appear on the KVM package, as we can only have dependencies on the kernel(*_ga) kernel package provides, that include only the whitelisted symbols.

We still need to filter some 'ksym(*)' dependencies that were not approved on the RHEL-5.4 whitelist, but we need to filter for the known entries, not all ksym dependencies.

The list of ksym dependencies has grown since bug #466961 has been filed, and we didn't notice because all ksym dependencies were being filtered. We need to change the current workaround to filter only known entries, not all ksym entries.

Comment 2 Eduardo Habkost 2009-11-06 19:20:50 UTC

This is the list of ksym dependencies that will be filtered:

# requested on bz#533401:
# -----------------------

# introduced on 2.6.18-148.el5:
ksym(iommu_attach_device) = afe845e8
ksym(iommu_detach_device) = 4fc56cce
ksym(iommu_domain_alloc) = 2eed2630
ksym(iommu_domain_free) = f4a8385f
ksym(iommu_found) = 20d22764

# introduced on 2.6.18-148.el5, with a different hash (3752c400).
# ABI changed to a5cbe1 on 2.6.18-149
ksym(iommu_iova_to_phys) = a5cbe1

# introduced on 2.6.18-148.el5, with a different hash (e0609a70)
# hash changed to 1381a048 on 2.6.18-149
ksym(iommu_map_range) = 1381a048

# introduced on 2.6.18-148.el5:
ksym(iommu_unmap_range) = 942a41f4

# introduced on 2.6.18-140.el5:
ksym(mmu_notifier_register) = 63b0946c
ksym(mmu_notifier_unregister) = a049a030

# introduced on 2.6.18-159.el5:
ksym(pci_reset_function) = 3b361139

# introduced a long time ago (2.6.18-53.el5, it seems):
ksym(tsc_khz) = 39e53c0d

# introduced a long time ago (older than 2.6.18-2.el5):
ksym(__dec_zone_page_state) = 8c99ac68
ksym(__inc_zone_page_state) = aeb8ed58
ksym(do_mm_track_pte) = ddcc15b8
ksym(mm_tracking_struct) = 61af69bd


# rejected (bz#466961), but needed by KVM:
# ----------------------------------------

# introduced on 2.6.18-115.el5:
ksym(preempt_notifier_register) = 1efa9a60
ksym(preempt_notifier_unregister) = d5fd504f

# introduced on 2.6.18-113.el5:
ksym(marker_probe_cb) = 6f9c2efe
ksym(marker_probe_register) = 7da8d037
ksym(marker_probe_unregister) = d027a07d
ksym(__mark_empty_function) = fecbff96

Comment 13 errata-xmlrpc 2010-03-30 07:54:43 UTC

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2010-0271.html