Bug 533247
Summary: | clvmd initscript [LSB|FedoraGuidelines] compliance | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Nate Straz <nstraz> | ||||
Component: | lvm2-cluster | Assignee: | Fabio Massimo Di Nitto <fdinitto> | ||||
Status: | CLOSED UPSTREAM | QA Contact: | Corey Marthaler <cmarthal> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | low | ||||||
Version: | 12 | CC: | agk, ccaulfie, dkovalsk, dwysocha, fdinitto, jbrassow, mbroz, prockai | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | |||||||
: | 553381 (view as bug list) | Environment: | |||||
Last Closed: | 2010-02-26 13:09:17 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 521669, 553381 | ||||||
Attachments: |
|
Description
Nate Straz
2009-11-05 19:12:51 UTC
Should the clvmd init script require cman is already started? If so, it should be included in the LSB header. This bug appears to have been reported against 'rawhide' during the Fedora 12 development cycle. Changing version to '12'. More information and reason for this action is here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping Created attachment 388811 [details]
Patch from Fabio
- fix whitespaces all over (tabs/spaces)
- use secure path
- remove hardcoding of paths for tools
- increase timeout to 30 secs (on Chrissie request)
- source both cluster and clvmd for options (like all the other cluster
init scripts)
- add clustered_vgs and _lvs commodity fns
- move rh_status* fns at the top, so they can be reused
- heavily cleanup start and stop fns from redundant code and unnecessary
loops
- drop wait_for_finish. According to docs killproc will send first
specified signals and then SIGKILL and do the way for us.
- improve output from status
- make the init script lsb compliant
Please review and let me know if we need to add more changes.
Both Chrissie and I have tested this new version.
Fabio
A new version of the init script has been committed in upstream CVS. |