Bug 534061

$ rpmlint hostname.spec 
hostname.spec: W: no-cleaning-of-buildroot %install
hostname.spec: W: no-buildroot-tag

other that that it looks to be an easy review.

(In reply to comment #1)
> $ rpmlint hostname.spec 
> hostname.spec: W: no-cleaning-of-buildroot %install
> hostname.spec: W: no-buildroot-tag
> 
> other that that it looks to be an easy review.  

https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
"The RPM in Fedora 10 defines a default buildroot so in Fedora 10 and above it is no longer necessary to define a buildroot tag."

https://fedoraproject.org/wiki/Packaging/Guidelines#Prepping_BuildRoot_For_.25install
"The current redhat-rpm-config package in Fedora 10 and newer automatically deletes and creates the buildroot at %install, so in Fedora 10 and newer, it is not necessary for packages to manually Prepare the BuildRoot for install as described below."

There should be "Up to now *hostname* has been part of net-tools package." in the description of this Review Request.

Those two rpmlint warnings are completely bogus; I'll report a bug against rpmlint.

(In reply to comment #4)
> Those two rpmlint warnings are completely bogus; I'll report a bug against
> rpmlint.  

If you read explanation of rpmlint you undarstand what all correct:
hostname.src: W: no-cleaning-of-buildroot %install
You should clean $RPM_BUILD_ROOT in the %clean section and in the beginning of
the %install section. Use "rm -rf $RPM_BUILD_ROOT". Some rpm configurations do
this automatically; if your package is only going to be built in such
configurations, you can ignore this warning for the section(s) where your rpm
takes care of it.

hostname.src: W: no-buildroot-tag
The BuildRoot tag isn't used in your spec. It must be used in order to allow
building the package as non root on some systems. For some rpm versions (e.g.
rpm.org >= 4.6) the BuildRoot tag is not necessary in specfiles and is ignored
by rpmbuild; if your package is only going to be built with such rpm versions
you can ignore this warning.

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1812747

Review of hostname:

yes: rpmlint

$ rpmlint hostname.spec ../SRPMS/hostname-3.01-1.fc13.src.rpm ../RPMS/x86_64/hostname-*fc13*
hostname.spec: W: no-cleaning-of-buildroot %install
hostname.spec: W: no-buildroot-tag
hostname.src: W: no-cleaning-of-buildroot %install
hostname.src: W: no-buildroot-tag
3 packages and 1 specfiles checked; 0 errors, 4 warnings.

which are fine as explained in Comment #2.

yes: Package is named well.
yes: spec file name good.
yes: meets packaging guidelines.
yes: packge marked as GPLv2+
yes: source matches GPLv2+
yes: COPYRIGHT file included.
yes: spec in english.
yes: spec legible.
yes: 
$ md5sum /tmp/hostname_3.01.tar.gz ~/rpmbuild/SOURCES/hostname_3.01.tar.gz 
866c4250583960bf730fb7a8815dbb03  /tmp/hostname_3.01.tar.gz
866c4250583960bf730fb7a8815dbb03  /home/steve/rpmbuild/SOURCES/hostname_3.01.tar.gz

yes: compiles, see koji build above.
yes: compiles for all arches, see koji.
yes: build deps sane, there are none.
yes: no localles present.
yes; contain no libraries.
yes: not relocatable.
yes: Everything in /bin doc or a man.
Yes: Does not create any directories.
yes: no file duplicates.
yes: All fikes are %defattr.
yes: clean buildroot on %clean.
yes: macro use consistant.
yes: Contains the hostname command.
yes: no large docs.
yes: docs not needed.
yes: no header files.
yes: no pkgconfig files.
yes: no .so files anyway.
yes: no devel packaes.
yes: no .la files.
yes: no gui present.
yes: does share files with net-tools < 1.60-99
     but has an explictit 
     Conflicts: net-tools < 1.60-99

     this is intentional and justified.
yes: %install does not need rm -rf with this new rpm.
yes: valid utf8.

APPROVED.

New Package CVS Request
=======================
Package Name: hostname
Short Description: Provides commands which can be used to display the system's DNS name, and to display or set its hostname or NIS domain name.
Owners: jpopelka

cvs done.