Bug 534917 (RHQ-1667)
| Summary: | Remove use of <!-- --> style comments from xhtml file | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Other] RHQ Project | Reporter: | Jay Shaughnessy <jshaughn> | ||||
| Component: | No Component | Assignee: | RHQ Project Maintainer <rhq-maint> | ||||
| Status: | CLOSED NOTABUG | QA Contact: | |||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 1.2 | Keywords: | SubBug | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| URL: | http://jira.rhq-project.org/browse/RHQ-1667 | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2010-08-20 15:01:17 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 565628 | ||||||
| Attachments: |
|
||||||
This bug was previously known as http://jira.rhq-project.org/browse/RHQ-1667 Imported an attachment (id=368602) Temporarily adding the keyword "SubBug" so we can be sure we have accounted for all the bugs. keyword: new = Tracking + FutureFeature + SubBug making sure we're not missing any bugs in rhq_triage Closing per 19-Aug-2010 triage |
(11:41:22 AM) jshaughn: mazz and I were just discussing issues that can result from <!-- --> style commenting in .xhtml. There are over 180 instances of this in our portal war .xhtml files. In general this will still work but he pointed out that having <!-- #{x} --> may cause problems. (11:41:52 AM) mazz: (which did cause problems yesterday in menu.xhtml -I checked in the fix yesterday by removing the entire "comment") (11:42:20 AM) jshaughn: We may want to remove these. (11:42:22 AM) pilhuhn: And I guess <!--${}--> as well ? (11:42:45 AM) mazz: yeah, ${} too Here are the hits under rhq/modules/enterprise/gui using the following regex to find single and multiline occurrences of html comments with either #{ or ${ embedded within: (?s)\<!--.*[\#\$]\{.*--\> See attachment for search results.