Bug 534917 (RHQ-1667) - Remove use of <!-- --> style comments from xhtml file
Summary: Remove use of <!-- --> style comments from xhtml file
Keywords:
Status: CLOSED NOTABUG
Alias: RHQ-1667
Product: RHQ Project
Classification: Other
Component: No Component
Version: 1.2
Hardware: All
OS: All
medium
medium
Target Milestone: ---
: ---
Assignee: RHQ Project Maintainer
QA Contact:
URL: http://jira.rhq-project.org/browse/RH...
Whiteboard:
Depends On:
Blocks: rhq_triage
TreeView+ depends on / blocked
 
Reported: 2009-02-25 17:17 UTC by Jay Shaughnessy
Modified: 2010-08-20 15:01 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-08-20 15:01:17 UTC
Embargoed:


Attachments (Terms of Use)
hits.jpg (76.65 KB, image/jpeg)
2009-02-25 17:18 UTC, Jay Shaughnessy
no flags Details

Description Jay Shaughnessy 2009-02-25 17:17:00 UTC
(11:41:22 AM) jshaughn: mazz and I were just discussing issues that can result from <!-- --> style commenting in .xhtml.  There are over 180 instances of this in our portal war .xhtml files.  In general this will still work but he pointed out that having <!-- #{x} --> may cause problems.
(11:41:52 AM) mazz: (which did cause problems yesterday in menu.xhtml -I checked in the fix yesterday by removing the entire "comment")
(11:42:20 AM) jshaughn: We may want to remove these.
(11:42:22 AM) pilhuhn: And I guess <!--${}--> as well ?
(11:42:45 AM) mazz: yeah, ${} too

Here are the hits under rhq/modules/enterprise/gui using the following regex to find single and multiline occurrences of html comments with either #{ or ${  embedded within:

(?s)\<!--.*[\#\$]\{.*--\>

See attachment for search results.


Comment 1 Red Hat Bugzilla 2009-11-10 20:37:51 UTC
This bug was previously known as http://jira.rhq-project.org/browse/RHQ-1667
Imported an attachment (id=368602)


Comment 2 wes hayutin 2010-02-16 16:55:08 UTC
Temporarily adding the keyword "SubBug" so we can be sure we have accounted for all the bugs.

keyword:
new = Tracking + FutureFeature + SubBug

Comment 3 wes hayutin 2010-02-16 17:00:16 UTC
making sure we're not missing any bugs in rhq_triage

Comment 4 Corey Welton 2010-08-20 15:01:17 UTC
Closing per 19-Aug-2010 triage


Note You need to log in before you can comment on or make changes to this bug.