Bug 535607 (RHQ-2285)
| Summary: | don't sendResourcError everytime getAvailability throws exception | ||
|---|---|---|---|
| Product: | [Other] RHQ Project | Reporter: | John Mazzitelli <mazz> |
| Component: | Plugin Container | Assignee: | RHQ Project Maintainer <rhq-maint> |
| Status: | CLOSED NOTABUG | QA Contact: | |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | unspecified | CC: | ccrouch, cwelton |
| Target Milestone: | --- | Keywords: | SubBug |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | http://jira.rhq-project.org/browse/RHQ-2285 | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-03-15 04:56:10 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 565628 | ||
ghinkle checked in svn rev 4810 that makes the sendResourceError NOT guaranteed - so it won't be sent again if it fails This bug was previously known as http://jira.rhq-project.org/browse/RHQ-2285 Temporarily adding the keyword "SubBug" so we can be sure we have accounted for all the bugs. keyword: new = Tracking + FutureFeature + SubBug making sure we're not missing any bugs in rhq_triage Do we even want to support this type of ResourceError going forward? I may be wrong, but I don't recall ever seeing this type of information in the server anywhere - we just show the latest AvailabilityType and availability history instead for each resource. The only type of ResourceError we actually propagate to the UI is the one for plugin configuration errors. In the last few weeks, we now support resource upgrade error types as well. Unless there is a good reason to keep this kind of error, and unless we actually want to show that error somewhere in the UI (and does that mean that the message should be guaranteed?), then I vote to get rid of it. Mazz, thoughts? we can get rid of this |
see AvailabilityExecutor - don't always sendResourceError in the catch if (resourceContainer.getResourceComponentState() == ResourceComponentState.STARTED) { current = resourceComponent.getAvailability(); } else { this.inventoryManager.activateResource(resource, resourceContainer, false); if (resourceContainer.getResourceComponentState() == ResourceComponentState.STARTED) { current = resourceComponent.getAvailability(); } } } catch (Throwable t) { ResourceError resourceError = new ResourceError(resource, ResourceErrorType.AVAILABILITY_CHECK, t, System.currentTimeMillis()); this.inventoryManager.sendResourceErrorToServer(resourceError); // TODO GH: Put errors in report, rather than sending them to the Server separately. if (log.isDebugEnabled()) { if (t instanceof TimeoutException) // no need to log the stack trace for timeouts... log.debug("Failed to collect availability on resource " + resource + " (call timed out)"); else log.debug("Failed to collect availability on resource " + resource, t); } }